Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPBackendRef ResponseHeaderModifier Conformance Test #2821

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

HTTPBackendRef ResponseHeaderModifier Conformance Test #2821

wants to merge 5 commits into from
+306 −181

Conversation

dprotaso
Copy link
Contributor

What type of PR is this?
/kind cleanup
/kind test
/area conformance

What this PR does / why we need it:

This adds test coverage for an extended feature - HTTPBackendRef being able to support the responseHeader filter

Which issue(s) this PR fixes:
N/A

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2024
@dprotaso
Copy link
Contributor Author

dprotaso commented Mar 7, 2024

adding approvers
/assign @arkodg @mlavacca @sunjayBhatia

adding reviewers
/cc @LiorLieberman @michaelbeaumont @Xunzhuo

@dprotaso
Copy link
Contributor Author

dprotaso commented Apr 1, 2024

Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @sunjayBhatia @michaelbeaumont @LiorLieberman @Xunzhuo

@dprotaso
Copy link
Contributor Author

dprotaso commented Apr 3, 2024

/retest

@dprotaso
Copy link
Contributor Author

Conformance reviewers/approvers - can I get review please @arkodg @mlavacca @sunjayBhatia @michaelbeaumont @LiorLieberman @Xunzhuo

Hoping this lands in v1.1 this week

@LiorLieberman
Copy link
Member

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 10, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dprotaso
Once this PR has been reviewed and has the lgtm label, please assign robscott for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@LiorLieberman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@robscott robscott mentioned this pull request Apr 22, 2024
Closed
@robscott
Copy link
Member

Thanks for the work on this @dprotaso! Before we merge something like this, I think it would be good to figure out #3009.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@mlavacca mlavacca mentioned this pull request Aug 19, 2024
Open
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@dprotaso: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-crds-validation-5 bd8f09c link true /test pull-gateway-api-crds-validation-5
pull-gateway-api-crds-validation-3 bd8f09c link true /test pull-gateway-api-crds-validation-3
pull-gateway-api-crds-validation-1 bd8f09c link true /test pull-gateway-api-crds-validation-1
pull-gateway-api-crds-validation-4 bd8f09c link true /test pull-gateway-api-crds-validation-4
pull-gateway-api-crds-validation-2 bd8f09c link true /test pull-gateway-api-crds-validation-2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@candita
Copy link
Contributor

candita commented Nov 7, 2024

ping @dprotaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@mlavacca mlavacca Awaiting requested review from mlavacca

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

Assignees

@sunjayBhatia sunjayBhatia

@arkodg arkodg

@mlavacca mlavacca

@LiorLieberman LiorLieberman

Labels
area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dprotaso @LiorLieberman @k8s-ci-robot @robscott @candita @michaelbeaumont @sunjayBhatia @arkodg @mlavacca