Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEP-1713: Standard Mechanism to Merge Gateway Listeners (rev 2) #3213

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

GEP-1713: Standard Mechanism to Merge Gateway Listeners (rev 2) #3213

wants to merge 31 commits into from

Commits on Jul 23, 2024

  1. Second Revision of GEP-1713

    @dprotaso
    dprotaso committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    71a9bab View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. fix minor nits

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    02c6a05 View commit details
    Browse the repository at this point in the history

  2. Drop section highlighting failure cases we can't handle

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    72b6b1e View commit details
    Browse the repository at this point in the history

  3. add enum validation

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bb40ff6 View commit details
    Browse the repository at this point in the history

  4. Describe the 'meta' details about this feature

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    9baad11 View commit details
    Browse the repository at this point in the history

  5. attaching to the Gateway's sectionName but through the ListenerSet ki… 

    …nd is not allowed
    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    41b1b21 View commit details
    Browse the repository at this point in the history

  6. ListenerSet can have multiple parents

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e221a16 View commit details
    Browse the repository at this point in the history

  7. Allow multiple parentRefs and adjust language around PolicyAttachment

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    67ec44f View commit details
    Browse the repository at this point in the history

  8. clarify which section has listener ordering

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    228a4f8 View commit details
    Browse the repository at this point in the history

  9. fix heading levels

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4ff2eb0 View commit details
    Browse the repository at this point in the history

  10. allow no listeners on the Gateway spec

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    879c011 View commit details
    Browse the repository at this point in the history

  11. add back istio use case

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    dd175c6 View commit details
    Browse the repository at this point in the history

  12. update gateway conditions paragraph

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6890bc3 View commit details
    Browse the repository at this point in the history

  13. don't say concatenate

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    460576f View commit details
    Browse the repository at this point in the history

  14. drop clause saying invalid listeners affects other listeners

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a46a001 View commit details
    Browse the repository at this point in the history

  15. clarify route attachment

    @dprotaso
    dprotaso committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    70261a1 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. split listenersetconditions into two sections: top-level and listener… 

    …status
    @dprotaso
    dprotaso committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    aa382cc View commit details
    Browse the repository at this point in the history

  2. clarify where the conflicted condition is set

    @dprotaso
    dprotaso committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    32fc59f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. relabel introduction => use cases

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    46dbf4e View commit details
    Browse the repository at this point in the history

  2. limit parents to 2 and listeners to 16

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    cf29a9a View commit details
    Browse the repository at this point in the history

  3. use separate listener and status types

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9356e1c View commit details
    Browse the repository at this point in the history

  4. ListenerSet attachment is opt-in

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    947af4f View commit details
    Browse the repository at this point in the history

  5. fix formatting

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    de19b26 View commit details
    Browse the repository at this point in the history

  6. fix more formatting

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6b8b753 View commit details
    Browse the repository at this point in the history

  7. include potential goals from the gateway hierarchy document

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    32308c9 View commit details
    Browse the repository at this point in the history

  8. fix language that allows a route to attach to both a listener set and… 

    … a gateway at the same time
    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d01d705 View commit details
    Browse the repository at this point in the history

  9. if a route tries to attach to a non-existent listener on the listener… 

    … set then Accepted should be false
    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    dd8a0f6 View commit details
    Browse the repository at this point in the history

  10. ListenerStatus => ListenerEntryStatus

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    cc11438 View commit details
    Browse the repository at this point in the history

  11. add a blurb about listenerset+gateway listeners are joined as a list

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5c00375 View commit details
    Browse the repository at this point in the history

  12. Gateways that fail should also fail their attached ListenerSets

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    54de622 View commit details
    Browse the repository at this point in the history

  13. don't leak secrets

    @dprotaso
    dprotaso committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8b338bc View commit details
    Browse the repository at this point in the history