Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #3400

Open
wants to merge 61 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
b1f5208
spelling: adding
jsoref Oct 18, 2024
bd35f53
spelling: anymore
jsoref Oct 16, 2024
33fafdc
spelling: approach
jsoref Oct 18, 2024
87c738a
spelling: attached
jsoref Oct 18, 2024
6322a33
spelling: because
jsoref Oct 18, 2024
2585a66
spelling: cannot
jsoref Oct 16, 2024
fcf6976
spelling: case-insensitive
jsoref Oct 16, 2024
3a8e19e
spelling: case-sensitive
jsoref Oct 16, 2024
74899a9
spelling: certificate
jsoref Oct 18, 2024
282dc82
spelling: certificates
jsoref Oct 18, 2024
7235662
spelling: configuration
jsoref Oct 18, 2024
5abd182
spelling: criteria
jsoref Oct 18, 2024
ef2cf47
spelling: deterministically
jsoref Oct 18, 2024
cc1a882
spelling: discoverability
jsoref Oct 18, 2024
3b722b7
spelling: docs
jsoref Oct 18, 2024
0aa20bf
spelling: encapsulated
jsoref Oct 18, 2024
f1a68bc
spelling: feature
jsoref Oct 21, 2024
fd0ab7e
spelling: filesystem
jsoref Oct 18, 2024
f791dbd
spelling: format
jsoref Oct 18, 2024
bdeb813
spelling: frankbu
jsoref Oct 18, 2024
f88fa6d
spelling: github
jsoref Oct 16, 2024
d996a81
spelling: grpc
jsoref Oct 21, 2024
f0ffbb7
spelling: grpcroute
jsoref Oct 18, 2024
bd52f92
spelling: has
jsoref Oct 16, 2024
341db08
spelling: have
jsoref Oct 21, 2024
771f542
spelling: http-route
jsoref Oct 18, 2024
c70af0a
spelling: httpproxy
jsoref Oct 18, 2024
ae52a6b
spelling: httpredirect
jsoref Oct 21, 2024
6d6f2a4
spelling: https
jsoref Oct 18, 2024
c294db4
spelling: implementation
jsoref Oct 18, 2024
ff59bab
spelling: improvements
jsoref Oct 18, 2024
d9ef37e
spelling: in
jsoref Oct 16, 2024
506eab3
spelling: infrastructure
jsoref Oct 21, 2024
8473829
spelling: into
jsoref Oct 16, 2024
0b79608
spelling: intuitive
jsoref Oct 18, 2024
f80438f
spelling: its
jsoref Oct 16, 2024
dd6ea6c
spelling: linked
jsoref Oct 18, 2024
f2b2f15
spelling: maintainers
jsoref Oct 18, 2024
96373b8
spelling: maintenance
jsoref Oct 18, 2024
d71825b
spelling: maximum
jsoref Oct 18, 2024
264f5a2
spelling: negotiated
jsoref Oct 21, 2024
84d09b1
spelling: networking
jsoref Oct 21, 2024
fc1f2e1
spelling: nonexistent
jsoref Oct 16, 2024
2ddf6ed
spelling: or
jsoref Oct 16, 2024
0a3553f
spelling: overridden
jsoref Oct 18, 2024
a5b0dec
spelling: possible
jsoref Oct 18, 2024
f4ee83e
spelling: preexisting
jsoref Oct 16, 2024
e6f1606
spelling: prominence
jsoref Oct 18, 2024
a36f67c
spelling: protocol
jsoref Oct 18, 2024
8580fef
spelling: recommend
jsoref Oct 18, 2024
06c41b8
spelling: reference-grant
jsoref Oct 18, 2024
dc1346a
spelling: referent
jsoref Oct 18, 2024
a0bf37d
spelling: release
jsoref Oct 18, 2024
312caba
spelling: route-override
jsoref Oct 18, 2024
bba9534
spelling: stabilizing
jsoref Oct 18, 2024
bafaf00
spelling: substituted
jsoref Oct 18, 2024
242f441
spelling: targeting
jsoref Oct 21, 2024
58e6025
spelling: the
jsoref Oct 16, 2024
a16f558
spelling: validationutil
jsoref Oct 18, 2024
0dcea2f
spelling: which
jsoref Oct 16, 2024
e9aac3d
Reword simplify prototyping description
jsoref Oct 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .openvex/templates/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ vexctl add --in-place main.openvex.json pkg:oci/test CVE-2014-1234567 fixed
That will add a new VEX statement expressing that the impact of
CVE-2014-1234567 is under investigation in the test image. When
cutting a new release, for `pkg:oci/test` the new file will be
incorporated to the relase's VEX data.
incorporated to the release's VEX data.

## Read more about OpenVEX

Expand Down
8 changes: 4 additions & 4 deletions CHANGELOG/0.x-CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ For more information refer to

- Added the missing ReferenceGrant resource the kustomization.yaml for the
standard channel (#2084, @howardjohn)
- Webhook validation now ensures that BackendRefs can not be specified in the
- Webhook validation now ensures that BackendRefs cannot be specified in the
same HTTPRoute rule as a Redirect filter (#2161, @slayer321)
- GRPCRoute: The default match has been removed as it was invalid (it only
specified a type of "Exact" without a corresponding Service or Method). Note
Expand Down Expand Up @@ -407,7 +407,7 @@ For more information, refer to

- Added the missing ReferenceGrant resource the kustomization.yaml for the
standard channel (#2084, @howardjohn)
- Webhook validation now ensures that BackendRefs can not be specified in the
- Webhook validation now ensures that BackendRefs cannot be specified in the
same HTTPRoute rule as a Redirect filter (#2161, @slayer321)

# v0.7.1
Expand Down Expand Up @@ -1089,7 +1089,7 @@ In this release, we've made two release channels available, `experimental` and
`standard`.

The `experimental` channel contains all resources and fields, while `standard`
contains only resources that mave moved to beta status.
contains only resources that have moved to beta status.

We've also added a way to flag particular fields within a resource as
experimental, and any fields marked in this way are only present in the
Expand Down Expand Up @@ -1274,7 +1274,7 @@ In this release, we've made two release channels available, `experimental` and
`standard`.

The `experimental` channel contains all resources and fields, while `standard`
contains only resources that mave moved to beta status.
contains only resources that have moved to beta status.

We've also added a way to flag particular fields within a resource as
experimental, and any fields marked in this way are only present in the
Expand Down
4 changes: 2 additions & 2 deletions CHANGELOG/1.0-CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Of course there's a lot more in this release:
- The condition reason `GatewayReasonAddressNotUsable` for `Programmed` has been
added to deal with situations where a static address has been provided for a
Gateway which is of a supported type, and is syntactically valid, but for some
reason it can not be used for this Gateway (e.g. the address is already in use
reason it cannot be used for this Gateway (e.g. the address is already in use
on the network).
(#2412 @shaneutt)

Expand Down Expand Up @@ -332,7 +332,7 @@ Of course there's a lot more in this release:
- The condition reason `GatewayReasonAddressNotUsable` for `Programmed` has been
added to deal with situations where a static address has been provided for a
Gateway which is of a supported type, and is syntactically valid, but for some
reason it can not be used for this Gateway (e.g. the address is already in use
reason it cannot be used for this Gateway (e.g. the address is already in use
on the network).
(#2412 @shaneutt)

Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG/1.2-CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ The Experimental `supportedFeatures` field in GatewayClass `status` has changed
from being a list of strings to being a list of objects/structs with a `name`
field.

This is to allow addding in extra information to each entry at a later date.
This is to allow adding in extra information to each entry at a later date.

Relevant PRs:

Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG/1.2-TEAM.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
| BackendProtocol Support | @dprotaso |
| HTTPRoute Retries | @mikemorris |
| Percentage-based request mirroring | @jakebennert |
| Backend TLS Config improvments | @mkosieradzki, @LiorLieberman |
| Backend TLS Config improvements | @mkosieradzki, @LiorLieberman |
| Named Route Rules | @guicassolato, @howardjohn |
| Conformance Profiles and Reports | @mlavacca, @shaneutt, @xtineskim |
| Gateway API Maintainers | @mlavacca, @robscott, @shaneutt, @youngnick |
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,16 @@ test.crds-validation:
conformance:
go test ${GO_TEST_FLAGS} -v ./conformance -run TestConformance -args ${CONFORMANCE_FLAGS}

# Install CRD's and example resources to a pre-existing cluster.
# Install CRD's and example resources to a preexisting cluster.
.PHONY: install
install: crd example

# Install the CRD's to a pre-existing cluster.
# Install the CRD's to a preexisting cluster.
.PHONY: crd
crd:
kubectl kustomize config/crd | kubectl apply -f -

# Install the example resources to a pre-existing cluster.
# Install the example resources to a preexisting cluster.
.PHONY: example
example:
hack/install-examples.sh
Expand Down
2 changes: 1 addition & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ The following steps must be done by one of the [Gateway API maintainers][gateway
- Run the `make build-install-yaml` command which will generate install files in the `release/` directory.
Attach these files to the GitHub release.
- Update the `README.md` and `site-src/guides/index.md` files to point links and examples to the new release.
- Update the implementation table path (`nav.Implementations.Comparison`) in the nav of `mkdocs.yml` to point to the latest release file (for example Implementation Comparison points to `implmenetation-table-v1.2.0.md`). Add the now past version under `Past Version Comparisons`, and edit the text blurb in `mkdocs-generate-conformance.py` to also reflect the added past version.
- Update the implementation table path (`nav.Implementations.Comparison`) in the nav of `mkdocs.yml` to point to the latest release file (for example Implementation Comparison points to `implementation-table-v1.2.0.md`). Add the now past version under `Past Version Comparisons`, and edit the text blurb in `mkdocs-generate-conformance.py` to also reflect the added past version.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this one...


#### For an **RC** release:
- Update `pkg/consts/consts.go` with the new semver tag (like `v1.2.0-rc1`) and any updates to the API review URL.
Expand Down
2 changes: 1 addition & 1 deletion apis/v1/grpcroute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ type GRPCRouteRule struct {
// Specifying the same filter multiple times is not supported unless explicitly
// indicated in the filter.
//
// If an implementation can not support a combination of filters, it must clearly
// If an implementation cannot support a combination of filters, it must clearly
// document that limitation. In cases where incompatible or unsupported
// filters are specified and cause the `Accepted` condition to be set to status
// `False`, implementations may use the `IncompatibleFilters` reason to specify
Expand Down
10 changes: 5 additions & 5 deletions apis/v1/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ type HTTPRouteRule struct {
// they are specified.
//
// Implementations MAY choose to implement this ordering strictly, rejecting
// any combination or order of filters that can not be supported. If implementations
// any combination or order of filters that cannot be supported. If implementations
// choose a strict interpretation of filter ordering, they MUST clearly document
// that behavior.
//
Expand All @@ -232,7 +232,7 @@ type HTTPRouteRule struct {
//
// All filters are expected to be compatible with each other except for the
// URLRewrite and RequestRedirect filters, which may not be combined. If an
// implementation can not support other combinations of filters, they must clearly
// implementation cannot support other combinations of filters, they must clearly
// document that limitation. In cases where incompatible or unsupported
// filters are specified and cause the `Accepted` condition to be set to status
// `False`, implementations may use the `IncompatibleFilters` reason to specify
Expand Down Expand Up @@ -487,7 +487,7 @@ const (
PathMatchExact PathMatchType = "Exact"

// Matches based on a URL path prefix split by `/`. Matching is
// case sensitive and done on a path element by element basis. A
// case-sensitive and done on a path element by element basis. A
// path element refers to the list of labels in the path split by
// the `/` separator. When specified, a trailing `/` is ignored.
//
Expand Down Expand Up @@ -596,7 +596,7 @@ type HTTPHeaderMatch struct {
Type *HeaderMatchType `json:"type,omitempty"`

// Name is the name of the HTTP Header to be matched. Name matching MUST be
// case insensitive. (See https://tools.ietf.org/html/rfc7230#section-3.2).
// case-insensitive. (See https://tools.ietf.org/html/rfc7230#section-3.2).
//
// If multiple entries specify equivalent header names, only the first
// entry with an equivalent name MUST be considered for a match. Subsequent
Expand Down Expand Up @@ -947,7 +947,7 @@ const (
// HTTPHeader represents an HTTP Header name and value as defined by RFC 7230.
type HTTPHeader struct {
// Name is the name of the HTTP Header to be matched. Name matching MUST be
// case insensitive. (See https://tools.ietf.org/html/rfc7230#section-3.2).
// case-insensitive. (See https://tools.ietf.org/html/rfc7230#section-3.2).
//
// If multiple entries specify equivalent header names, the first entry with
// an equivalent name MUST be considered for a match. Subsequent entries
Expand Down
8 changes: 4 additions & 4 deletions apis/v1/shared_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ type RouteParentStatus struct {
// There are a number of cases where the "Accepted" condition may not be set
// due to lack of controller visibility, that includes when:
//
// * The Route refers to a non-existent parent.
// * The Route refers to a nonexistent parent.
// * The Route is of a type that the controller does not support.
// * The Route is in a namespace the controller does not have access to.
//
Expand Down Expand Up @@ -675,7 +675,7 @@ type GatewayController string
// Invalid values include:
//
// * example~ - "~" is an invalid character
// * example.com. - can not start or end with "."
// * example.com. - cannot start or end with "."
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
Expand Down Expand Up @@ -705,7 +705,7 @@ type AnnotationValue string
// Invalid values include:
//
// * example~ - "~" is an invalid character
// * example.com. - can not start or end with "."
// * example.com. - cannot start or end with "."
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
Expand Down Expand Up @@ -771,7 +771,7 @@ const (
// (see [RFC 5952](https://tools.ietf.org/html/rfc5952)).
//
// This type is intended for specific addresses. Address ranges are not
// supported (e.g. you can not use a CIDR range like 127.0.0.0/24 as an
// supported (e.g. you cannot use a CIDR range like 127.0.0.0/24 as an
// IPAddress).
//
// Support: Extended
Expand Down
4 changes: 2 additions & 2 deletions apis/v1/util/validation/gatewayclass_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"testing"

gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
validationtutils "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation"
validationutil "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes it consistent w/ another user...

)

func TestIsControllerNameValid(t *testing.T) {
Expand Down Expand Up @@ -58,7 +58,7 @@ func TestIsControllerNameValid(t *testing.T) {

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
isValid := validationtutils.IsControllerNameValid(tc.controllerName)
isValid := validationutil.IsControllerNameValid(tc.controllerName)
if isValid != tc.isvalid {
t.Errorf("Expected validity %t, got %t", tc.isvalid, isValid)
}
Expand Down
4 changes: 2 additions & 2 deletions apis/v1alpha2/shared_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ type GatewayController = v1.GatewayController
// Invalid values include:
//
// * example~ - "~" is an invalid character
// * example.com. - can not start or end with "."
// * example.com. - cannot start or end with "."
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
Expand Down Expand Up @@ -360,7 +360,7 @@ const (
// (see [RFC 5952](https://tools.ietf.org/html/rfc5952)).
//
// This type is intended for specific addresses. Address ranges are not
// supported (e.g. you can not use a CIDR range like 127.0.0.0/24 as an
// supported (e.g. you cannot use a CIDR range like 127.0.0.0/24 as an
// IPAddress).
//
// Support: Extended
Expand Down
2 changes: 1 addition & 1 deletion apis/v1alpha2/tcproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ type TCPRouteRule struct {
Name *SectionName `json:"name,omitempty"`

// BackendRefs defines the backend(s) where matching requests should be
// sent. If unspecified or invalid (refers to a non-existent resource or a
// sent. If unspecified or invalid (refers to a nonexistent resource or a
// Service with no endpoints), the underlying implementation MUST actively
// reject connection attempts to this backend. Connection rejections must
// respect weight; if an invalid backend is requested to have 80% of
Expand Down
2 changes: 1 addition & 1 deletion apis/v1alpha2/tlsroute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ type TLSRouteRule struct {
Name *SectionName `json:"name,omitempty"`

// BackendRefs defines the backend(s) where matching requests should be
// sent. If unspecified or invalid (refers to a non-existent resource or
// sent. If unspecified or invalid (refers to a nonexistent resource or
// a Service with no endpoints), the rule performs no forwarding; if no
// filters are specified that would result in a response being sent, the
// underlying implementation must actively reject request attempts to this
Expand Down
2 changes: 1 addition & 1 deletion apis/v1alpha2/udproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ type UDPRouteRule struct {
Name *SectionName `json:"name,omitempty"`

// BackendRefs defines the backend(s) where matching requests should be
// sent. If unspecified or invalid (refers to a non-existent resource or a
// sent. If unspecified or invalid (refers to a nonexistent resource or a
// Service with no endpoints), the underlying implementation MUST actively
// reject connection attempts to this backend. Packet drops must
// respect weight; if an invalid backend is requested to have 80% of
Expand Down
2 changes: 1 addition & 1 deletion apis/v1alpha3/backendtlspolicy_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ type BackendTLSPolicyValidation struct {
//
// If CACertificateRefs is empty or unspecified, then WellKnownCACertificates must be
// specified. Only one of CACertificateRefs or WellKnownCACertificates may be specified,
// not both. If CACertifcateRefs is empty or unspecified, the configuration for
// not both. If CACertificateRefs is empty or unspecified, the configuration for
// WellKnownCACertificates MUST be honored instead if supported by the implementation.
//
// References to a resource in a different namespace are invalid for the
Expand Down
4 changes: 2 additions & 2 deletions apis/v1beta1/shared_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ type GatewayController = v1.GatewayController
// Invalid values include:
//
// * example~ - "~" is an invalid character
// * example.com. - can not start or end with "."
// * example.com. - cannot start or end with "."
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
Expand Down Expand Up @@ -360,7 +360,7 @@ const (
// (see [RFC 5952](https://tools.ietf.org/html/rfc5952)).
//
// This type is intended for specific addresses. Address ranges are not
// supported (e.g. you can not use a CIDR range like 127.0.0.0/24 as an
// supported (e.g. you cannot use a CIDR range like 127.0.0.0/24 as an
// IPAddress).
//
// Support: Extended
Expand Down
4 changes: 2 additions & 2 deletions apis/v1beta1/util/validation/gatewayclass_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
"testing"

gatewayv1b1 "sigs.k8s.io/gateway-api/apis/v1beta1"
validationtutils "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation"
validationutil "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation"
)

func TestIsControllerNameValid(t *testing.T) {
Expand Down Expand Up @@ -58,7 +58,7 @@ func TestIsControllerNameValid(t *testing.T) {

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
isValid := validationtutils.IsControllerNameValid(tc.controllerName)
isValid := validationutil.IsControllerNameValid(tc.controllerName)
if isValid != tc.isvalid {
t.Errorf("Expected validity %t, got %t", tc.isvalid, isValid)
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading