generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #3400
Open
jsoref
wants to merge
61
commits into
kubernetes-sigs:main
Choose a base branch
from
jsoref:spelling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Spelling #3400
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
b1f5208
spelling: adding
jsoref bd35f53
spelling: anymore
jsoref 33fafdc
spelling: approach
jsoref 87c738a
spelling: attached
jsoref 6322a33
spelling: because
jsoref 2585a66
spelling: cannot
jsoref fcf6976
spelling: case-insensitive
jsoref 3a8e19e
spelling: case-sensitive
jsoref 74899a9
spelling: certificate
jsoref 282dc82
spelling: certificates
jsoref 7235662
spelling: configuration
jsoref 5abd182
spelling: criteria
jsoref ef2cf47
spelling: deterministically
jsoref cc1a882
spelling: discoverability
jsoref 3b722b7
spelling: docs
jsoref 0aa20bf
spelling: encapsulated
jsoref f1a68bc
spelling: feature
jsoref fd0ab7e
spelling: filesystem
jsoref f791dbd
spelling: format
jsoref bdeb813
spelling: frankbu
jsoref f88fa6d
spelling: github
jsoref d996a81
spelling: grpc
jsoref f0ffbb7
spelling: grpcroute
jsoref bd52f92
spelling: has
jsoref 341db08
spelling: have
jsoref 771f542
spelling: http-route
jsoref c70af0a
spelling: httpproxy
jsoref ae52a6b
spelling: httpredirect
jsoref 6d6f2a4
spelling: https
jsoref c294db4
spelling: implementation
jsoref ff59bab
spelling: improvements
jsoref d9ef37e
spelling: in
jsoref 506eab3
spelling: infrastructure
jsoref 8473829
spelling: into
jsoref 0b79608
spelling: intuitive
jsoref f80438f
spelling: its
jsoref dd6ea6c
spelling: linked
jsoref f2b2f15
spelling: maintainers
jsoref 96373b8
spelling: maintenance
jsoref d71825b
spelling: maximum
jsoref 264f5a2
spelling: negotiated
jsoref 84d09b1
spelling: networking
jsoref fc1f2e1
spelling: nonexistent
jsoref 2ddf6ed
spelling: or
jsoref 0a3553f
spelling: overridden
jsoref a5b0dec
spelling: possible
jsoref f4ee83e
spelling: preexisting
jsoref e6f1606
spelling: prominence
jsoref a36f67c
spelling: protocol
jsoref 8580fef
spelling: recommend
jsoref 06c41b8
spelling: reference-grant
jsoref dc1346a
spelling: referent
jsoref a0bf37d
spelling: release
jsoref 312caba
spelling: route-override
jsoref bba9534
spelling: stabilizing
jsoref bafaf00
spelling: substituted
jsoref 242f441
spelling: targeting
jsoref 58e6025
spelling: the
jsoref a16f558
spelling: validationutil
jsoref 0dcea2f
spelling: which
jsoref e9aac3d
Reword simplify prototyping description
jsoref File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ import ( | |
"testing" | ||
|
||
gatewayv1 "sigs.k8s.io/gateway-api/apis/v1" | ||
validationtutils "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation" | ||
validationutil "sigs.k8s.io/gateway-api/apis/v1beta1/util/validation" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this makes it consistent w/ another user... |
||
) | ||
|
||
func TestIsControllerNameValid(t *testing.T) { | ||
|
@@ -58,7 +58,7 @@ func TestIsControllerNameValid(t *testing.T) { | |
|
||
for _, tc := range testCases { | ||
t.Run(tc.name, func(t *testing.T) { | ||
isValid := validationtutils.IsControllerNameValid(tc.controllerName) | ||
isValid := validationutil.IsControllerNameValid(tc.controllerName) | ||
if isValid != tc.isvalid { | ||
t.Errorf("Expected validity %t, got %t", tc.isvalid, isValid) | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
config/crd/experimental/gateway.networking.k8s.io_backendtlspolicies.yaml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this one...