Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error reporting to Temporary while Creating Volume #925

Open
riteshghorse opened this issue Aug 7, 2024 · 2 comments · Fixed by #924 · May be fixed by #971
Open

Change error reporting to Temporary while Creating Volume #925

riteshghorse opened this issue Aug 7, 2024 · 2 comments · Fixed by #924 · May be fixed by #971
Assignees

Comments

@riteshghorse
Copy link
Contributor

When CreateVolume is called, the csi-provisioner expects either "final" or "temporary" errors. If we report final error when Filestore instance creation could be ongoing or it is already created, then a PVC deletion before successful volume creation could lead to resource leakage as DeleteVolume won't happen.

This is already done for gcp-compute-persistent-disk-csi-driver.

PRs:

@riteshghorse
Copy link
Contributor Author

/assign

@leiyiz
Copy link
Contributor

leiyiz commented Sep 25, 2024

From #924: handling the metrics for new Temporary error types. This will be done in separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment