Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error reporting to temporary in CreateVolume workflow #924

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Change error reporting to temporary in CreateVolume workflow #924

merged 3 commits into from
Sep 6, 2024

Conversation

riteshghorse
Copy link
Contributor

@riteshghorse riteshghorse commented Aug 7, 2024 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
When CreateVolume is called, the csi-provisioner expects either "final" or "temporary" errors. If we report final error when Filestore instance creation could be ongoing or it is already created, then a PVC deletion before successful volume creation could lead to resource leakage as DeleteVolume won't happen.

Which issue(s) this PR fixes:
Fixes #925

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 7, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @riteshghorse. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 7, 2024
@riteshghorse
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 7, 2024
@riteshghorse
Copy link
Contributor Author

riteshghorse commented Aug 7, 2024 •
edited
Loading

CC: @eipi-one

@saikat-royc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 7, 2024
@riteshghorse
Copy link
Contributor Author

/retest

@riteshghorse riteshghorse marked this pull request as ready for review August 14, 2024 05:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 14, 2024
@riteshghorse
Copy link
Contributor Author

Friendly ping! @leiyiz @tyuchn

Pankaj (@eipi-one) will send another PR to update the metrics after this

leiyiz
leiyiz reviewed Aug 16, 2024
View reviewed changes
pkg/csi_driver/multishare_stateful_controller.go Outdated Show resolved Hide resolved
pkg/csi_driver/controller.go Outdated Show resolved Hide resolved
pkg/csi_driver/controller.go Outdated Show resolved Hide resolved
@leiyiz
Copy link
Contributor

leiyiz commented Aug 23, 2024

/retest

@leiyiz
Copy link
Contributor

leiyiz commented Aug 29, 2024

/retest

leiyiz
leiyiz reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general, just 1 last comment.

pkg/csi_driver/controller.go Show resolved Hide resolved
pkg/csi_driver/multishare_controller.go Show resolved Hide resolved
@leiyiz
Copy link
Contributor

leiyiz commented Aug 29, 2024

/retest

leiyiz
leiyiz reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, riteshghorse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
@riteshghorse
Copy link
Contributor Author

/remove-hold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2fbd1f1 into kubernetes-sigs:master Sep 6, 2024
7 checks passed
@riteshghorse riteshghorse deleted the resource-leak branch September 6, 2024 05:55
@leiyiz leiyiz mentioned this pull request Sep 25, 2024
Open
@eipi-one eipi-one mentioned this pull request Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz leiyiz left review comments

@eipi-one eipi-one eipi-one left review comments

@judemars judemars Awaiting requested review from judemars

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@leiyiz leiyiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change error reporting to Temporary while Creating Volume
5 participants
@riteshghorse @k8s-ci-robot @saikat-royc @leiyiz @eipi-one