-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasm-shims to v0.11.1 #1405
Conversation
/cc @hrak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to ask if we mind this is tagged "pre-release" in their release... then realised every one of them are! 😆
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
It appears they've re-released v0.11.0 inline, so the SHAs no longer match. (There's a good reason tags and releases should be considered write-only. See deislabs/containerd-wasm-shims#211 (comment).) Sorry about the churn! Let me update this. Edit: v0.11.0 release still isn't complete, so I'll put this on hold. |
/hold |
403cdd0
to
601f276
Compare
/retitle Update wasm-shims to v0.11.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest 500 downloading a file from GitHub...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AverageMarcus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Updates wasm-shims to v0.11.0.
Release notes: https://github.com/deislabs/containerd-wasm-shims/releases/tag/v0.11.0
Which issue(s) this PR fixes):
N/A
Additional context