Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-shims to v0.11.1 #1405

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

mboersma
Copy link
Contributor

What this PR does / why we need it:

Updates wasm-shims to v0.11.0.

Release notes: https://github.com/deislabs/containerd-wasm-shims/releases/tag/v0.11.0

Which issue(s) this PR fixes):

N/A

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 13, 2024
@mboersma
Copy link
Contributor Author

/cc @hrak

@k8s-ci-robot k8s-ci-robot requested a review from hrak February 13, 2024 19:37
Copy link
Contributor

@drew-viles drew-viles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ask if we mind this is tagged "pre-release" in their release... then realised every one of them are! 😆

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@mboersma
Copy link
Contributor Author

mboersma commented Feb 14, 2024

It appears they've re-released v0.11.0 inline, so the SHAs no longer match. (There's a good reason tags and releases should be considered write-only. See deislabs/containerd-wasm-shims#211 (comment).)

Sorry about the churn! Let me update this.

Edit: v0.11.0 release still isn't complete, so I'll put this on hold.

@mboersma
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2024
@mboersma
Copy link
Contributor Author

/retitle Update wasm-shims to v0.11.1
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot changed the title Update wasm-shims to v0.11.0 Update wasm-shims to v0.11.1 Feb 15, 2024
Copy link
Contributor

@drew-viles drew-viles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mboersma
Copy link
Contributor Author

/retest

500 downloading a file from GitHub...

failed: [default] (item=spin) => {"ansible_loop_var": "item", "changed": false, "dest": "/tmp/spin_wasm_shim.tar.gz", "elapsed": 0, "item": "spin", "msg": "Request failed", "response": "HTTP Error 500: Internal Server Error", "status_code": 500, "url": "https://github.com/deislabs/containerd-wasm-shims/releases/download/v0.11.1/containerd-wasm-shims-v2-spin-linux-x86_64.tar.gz"}�[0m

Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 49b94b1 into kubernetes-sigs:main Feb 16, 2024
11 checks passed
@mboersma mboersma deleted the bump-wasm-shims branch December 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants