-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation for GKE Security Policy #191
Add translation for GKE Security Policy #191
Conversation
/assign @robscott |
4102fc4
to
c447c71
Compare
/assign @spencerhance |
c447c71
to
9bb6d71
Compare
9bb6d71
to
3fcb656
Compare
3fcb656
to
f6ee19f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move all the sessionaffinity changes into a separate PR?
All changes related to session affinity are refactors, are you suggesting put refactor into its own PR and the new feature |
Yes that would be great. I know this PR isn't huge but generally decoupling refactors from new feature implementations helps reviewers (and |
f6ee19f
to
6599f9c
Compare
6599f9c
to
525d180
Compare
525d180
to
36ec5f2
Compare
36ec5f2
to
aee7145
Compare
aee7145
to
825bd31
Compare
@sawsa307 Can you ping me after you rebase and i'll take another look? |
825bd31
to
f1bed7d
Compare
I just did the rebase, please let me know if there is any other question, thanks! @spencerhance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, sawsa307, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adding a new feature for GKE Ingress and Gateway conversion.
Which issue(s) this PR fixes:
Adding more feature for #87.
Does this PR introduce a user-facing change?: