update gen-sdk.sh to generate sdk using docker container

[epicseven-cup]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Updates sdk generation using docker container

Which issue(s) this PR fixes:

Fixes #190

Special notes for your reviewer:

This is a draft pr

Does this PR introduce a user-facing change?

None

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: epicseven-cup / name: Jacky (abe1d45, e81b842, a4bd93a, 611b144, 1ad7b04, 0490392, 1642539, 2843c4d, 9747188, 44a9dff, 712dcfb, cdd94de, b248701)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: epicseven-cup
Once this PR has been reviewed and has the lgtm label, please assign danielvegamyhre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @epicseven-cup!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @epicseven-cup. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name	Link
🔨 Latest commit	712dcfb
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/67624bbb94e3290008e1a015

[epicseven-cup]

Hi sorry for all these message, this is currently a draft pr.

The direction I was going was to just use the openapi tool docker image to generate the sdk within the gen-sdk.sh script.

I will need to up some of the old apt installs and move the generated sdk correctly though feel free to take a look

[danielvegamyhre]

/ok-to-test

[danielvegamyhre]

Hi sorry for all these message, this is currently a draft pr.

The direction I was going was to just use the openapi tool docker image to generate the sdk within the gen-sdk.sh script.

I will need to up some of the old apt installs and move the generated sdk correctly though feel free to take a look

No worries, tag me when it is ready for review or if you have any questions

[epicseven-cup]

/retest

[epicseven-cup]

I removed to docker installed process so it will be similar to the python sdk docker setup

[epicseven-cup]

Hmm seems like it is expecting a docker install ./hack/python-sdk/gen-sdk.sh: line 50: docker: command not found

[epicseven-cup]

Hi @kannon92 @danielvegamyhre @ahg-g just a quick update from the information I got from slack. I'm going to submit a image change for jobset, by including docker into the image allowing the open api tool to be run in docker container

[kannon92]

/test

[k8s-ci-robot]

@kannon92: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

• /test pull-jobset-test-e2e-main-1-28
• /test pull-jobset-test-e2e-main-1-29
• /test pull-jobset-test-e2e-main-1-30
• /test pull-jobset-test-e2e-main-1-31
• /test pull-jobset-test-integration-main
• /test pull-jobset-test-unit-main
• /test pull-jobset-verify-main

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ahg-g]

Is this PR still relevant?

[epicseven-cup]

Is this PR still relevant?

Yup, sorry I hadn't gotten time to submit a PR for the testing image update to include docker. I will get this in by next week

[epicseven-cup]

I added the pr for image update to include podman (since it requires less changes to the image building process). kubernetes/test-infra#33955

[epicseven-cup]

I made a new pr to enable docker-in-docker for the pull-job-verify-main image, here is the link kubernetes/test-infra#33977

[ahg-g]

/retest

[ahg-g]

/retest

[ahg-g]

can you please cleanup this code?

[epicseven-cup]

Looks like I still need to start the docker daemon within the pull-jobset-verify-main job image, I will check on that as well

[k8s-ci-robot]

@epicseven-cup: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-jobset-verify-main	712dcfb	link	true	/test pull-jobset-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.