-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom kwok instance-types at runtime #1847
base: main
Are you sure you want to change the base?
feat: allow custom kwok instance-types at runtime #1847
Conversation
Hi @alec-rabold. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a1ea0e0
to
36c0872
Compare
Pull Request Test Coverage Report for Build 12045581115Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alec-rabold, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Looking for review from @njtran as well |
/ok-to-test |
/assign @njtran |
Description
Implements #1848
Adds a new flag and environment variable to the KWOK cloud-provider to provide a way to use custom instance-types at runtime (currently requires recompiling). The main use-case is not having to maintain a unique image for each combination of instance-types.
Included some boiler-plate for options; can remove if preferred
How was this change tested?
Locally tested with default and custom instance-types
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.