Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Start E2E montitioning controllers at the start of the test suite #1878

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: Start E2E montitioning controllers at the start of the test suite #1878

merged 2 commits into from
Jan 17, 2025

Conversation

engedaam
Copy link
Contributor

Fixes #N/A

Description

  • Fix monitoring controllers getting registered at the start of each test run

How was this change tested?

  • Tested in a forked branch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2024
@coveralls
Copy link

coveralls commented Dec 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12834618357

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 81.246%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 94.81%
Totals Coverage Status
Change from base Build 12820110848: 0.06%
Covered Lines: 9089
Relevant Lines: 11187
💛 - Coveralls

@jonathan-innis
Copy link
Member

/assign jonathan-innis

@github-actions GitHub Actions
Copy link

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2024
@github-actions github-actions bot closed this Jan 11, 2025
@engedaam
Copy link
Contributor Author

/open

@engedaam
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

@engedaam: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot removed lifecycle/closed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2025
jmdeal
jmdeal approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2025
jonathan-innis
jonathan-innis approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jmdeal, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit ff44f73 into kubernetes-sigs:main Jan 17, 2025
12 checks passed
@engedaam engedaam deleted the fix-e2e-test-run branch January 18, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal jmdeal approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@jmdeal jmdeal

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@engedaam @coveralls @jonathan-innis @k8s-ci-robot @jmdeal