-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix topology spread constraints with zonal volume #1907
base: main
Are you sure you want to change the base?
fix: Fix topology spread constraints with zonal volume #1907
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leoryu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @leoryu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c355d14
to
a993af1
Compare
Pull Request Test Coverage Report for Build 12735266711Details
💛 - Coveralls |
6d8d793
to
1dbfa0a
Compare
1dbfa0a
to
420766f
Compare
@jmdeal @engedaam @tallaxes @jonathan-innis @njtran hi, can you help review this PR? |
Fixes #1239
Description
At present, topology spread constraints in karpenter has 3 problems:
min-counts
domain from the eligible domains as the requirement, but the instance with this domain may not be compatible with the volume requirement(s).The major works of this PR are as follows:
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.