-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: update wait command for nginx ingress setup #3773
base: main
Are you sure you want to change the base?
Fix: update wait command for nginx ingress setup #3773
Conversation
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ShaikYams97 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ShaikYams97! |
Hi @ShaikYams97. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This pull request updates the wait command in the nginx ingress setup documentation to address timing issues on slower systems. The original documentation suggested waiting for the ingress controller pod readiness, but did not account for the time required for ingress-nginx-admission-patch and ingress-nginx-admission-create jobs to complete, especially on slower networks or systems.
Changes:
1.)Added a command to wait for the ingress-nginx-admission-patch job to complete before checking the readiness of the ingress controller.
2.)Updated command sequence:
kubectl wait --namespace ingress-nginx
--for=condition=complete job/ingress-nginx-admission-patch
--timeout=30s
&&
kubectl wait --namespace ingress-nginx
--for=condition=ready pod
--selector=app.kubernetes.io/component=controller
--timeout=90s
This improvement will prevent premature command errors (such as no matching resources found) by ensuring the patch job has completed before readiness is checked.
Issue Reference: Resolves #2293