Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saconfig plugin #4249

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

larsks
Copy link
Contributor

@larsks larsks commented Nov 30, 2024

The saconfig plugin generates a kubeconfig file for authenticating
as a service account.

Signed-off-by: Lars Kellogg-Stedman [email protected]

@ahmetb
Copy link
Member

ahmetb commented Nov 30, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin labels Nov 30, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @larsks!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 30, 2024
@larsks larsks force-pushed the plugin/saconfig branch 2 times, most recently from 6105bdb to c803da5 Compare November 30, 2024 22:07
@ahmetb
Copy link
Member

ahmetb commented Dec 1, 2024

I think there's already a plugin that does this: view-serviceaccount-kubeconfig.

@larsks
Copy link
Contributor Author

larsks commented Dec 1, 2024

The existing plugin does not make use of the tokenRequest API, which means it doesn't work unless there's already a pre-existing secret with a token.

Unrelated to that, rejecting plugins because "there's already a similar one here" seems like a great way to discourage contributions (and seems inconsistent, given e.g. the profusion of context and/or namespace management plugins in the index).

The saconfig plugin generates a kubeconfig file for authenticating
as a service account.

Signed-off-by: Lars Kellogg-Stedman <[email protected]>
@ahmetb
Copy link
Member

ahmetb commented Dec 9, 2024

We typically don’t accept there are identical plugins, however typically plugins different in their approaches to the same problem are fine. Some plugins also historically have been added long before the others before we instituted better curation policies.

/lgtm
/approve
Thanks!
Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, larsks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7d10673 into kubernetes-sigs:master Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants