-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add saconfig plugin #4249
Add saconfig plugin #4249
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
Welcome @larsks! |
6105bdb
to
c803da5
Compare
I think there's already a plugin that does this: view-serviceaccount-kubeconfig. |
c803da5
to
df11aad
Compare
The existing plugin does not make use of the tokenRequest API, which means it doesn't work unless there's already a pre-existing secret with a token. Unrelated to that, rejecting plugins because "there's already a similar one here" seems like a great way to discourage contributions (and seems inconsistent, given e.g. the profusion of context and/or namespace management plugins in the index). |
df11aad
to
780197d
Compare
The saconfig plugin generates a kubeconfig file for authenticating as a service account. Signed-off-by: Lars Kellogg-Stedman <[email protected]>
780197d
to
5f32516
Compare
We typically don’t accept there are identical plugins, however typically plugins different in their approaches to the same problem are fine. Some plugins also historically have been added long before the others before we instituted better curation policies. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, larsks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The saconfig plugin generates a kubeconfig file for authenticating
as a service account.
Signed-off-by: Lars Kellogg-Stedman [email protected]