-
Notifications
You must be signed in to change notification settings - Fork 1.6k
📖 Improve collapsible code sections and formatting of tutorials #5175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
📖 Improve collapsible code sections and formatting of tutorials #5175
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b0f9039 to
b1949ee
Compare
b1949ee to
ac9724d
Compare
691368a to
bb292f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy button seems to not be working correctly when we insert the code using the directive {{#literatego}}.
As a suggestion, what would happen if we wrapped the directives in a codeblock, like this:
```go
{{#literatego ./getting-started/testdata/project/api/v1alpha1/memcached_types.go}}
```
|
@camilamacedo86 I suggested ealier that we tried wrapping the And that raises the question: why do we start some parts in a markdown file, then continue the page by inserting comments in the file that was inserted? As an example, let's consider this page: https://book.kubebuilder.io/cronjob-tutorial/empty-main We start it here: https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/cronjob-tutorial/empty-main.md Then we insert this file: https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/cronjob-tutorial/testdata/emptymain.go And then we add comments to that file to continue the instructions in the page. So, couldn't we keep all the instruction in markdown files, and add only the sections of code that we need? That way, we could wrap each section in a codeblock, to be rendered properly, with the copy button. See: https://rust-lang.github.io/mdBook/format/mdbook.html?highlight=hide#including-portions-of-a-file |
7777c59 to
9139489
Compare
Assisted-by: Cursor
9139489 to
c564aed
Compare
|
I reverted the copy button changes Btw, thank you a lot for all the help !!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 I checked the preview and it seems that some copy buttons are still missing. See: https://deploy-preview-5175--kubebuilder.netlify.app/cronjob-tutorial/empty-main#every-journey-needs-a-start-every-program-needs-a-main
In code blocks that they are not missing, they are misplaced. See: https://deploy-preview-5175--kubebuilder.netlify.app/cronjob-tutorial/cronjob-tutorial#scaffolding-out-our-project
The custom CSS seems to be affecting how the copy buttons are displayed.
For testing, I checked out your PR and served the book using mdBook v0.4.40, then I deleted the custom CSS to see what happens and all the code blocks displayed the copy button properly (other parts broke, though 😅):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
I will be looking on that
Good catcher.
The following changes impact mainly the tutorials.
To review see:
Documentation Improvements Summary
Changes
New Features:
Layout:
Content Cleanup:
}appearing outside code blocksLabel Updates:
Closes: #4862