chore: run go test in ci workflow

[eddycharly]

This PR runs go test in CI workflow.

[eddycharly]

Anything I should do to avoid this ?

[apelisse]

You'd need to be an org member or something? I can look that up right after.

[eddycharly]

I think i'm a k/k member, maybe it's not enough ?

[eddycharly]

Now test fail 🤔

[apelisse]

That seems completely unrelated? is that a flake?

[eddycharly]

Not failing locally, checking.

[eddycharly]

Ahah, i had a cluster running locally, once i deleted it test started to fail.

[apelisse]

Ohhh, that's fishy, the tests should definitely not depend on your running environment ...

[eddycharly]

Ohhh, that's fishy, the tests should definitely not depend on your running environment ...

  openapiclient.NewLocalFiles(c.localFilesDir), // satisfy expectation users' expectation that provided local files are used
  openapiclient.NewLocalCRDFiles(c.localFilesDir),

Is this expected that we use the same dir for those two clients in the chain ?
First one is supposed to load openapi schema files and second is supposed to load CRD definitions.

[apelisse]

Yeah, I think it's loading all the files and then decides if they are openapi or CRDs (from which we extract the openapi). That should be fine, WDYT?

[eddycharly]

My 2 cents is we could provide two flags, nothing prevents those two flags to point at the same dir.
It will allow using different folders.

[eddycharly]

And if I apply the fix in #26 test panics 🤔

[apelisse]

My 2 cents is we could provide two flags, nothing prevents those two flags to point at the same dir.
It will allow using different folders.

Go for it :-)

[apelisse]

Let's see if @alexzielenski can help?

[eddycharly]

Sure, from what I understand, tests are going to depend on the kubernetes version flag ? (because validation and message can vary slightly)

[apelisse]

Anything I should do to avoid this ?

Your name shows "contributor", not "member", that's probably why. If you're a k/k member, you almost certainly can be a kubernetes-sigs member too, especially with the help you give us here.

[alexzielenski]

Since the tests are making use of the RootCommand they get openapiclient.NewKubeConfig(c.kubeConfigOverrides), added automatically. We should add a way to disable that in tests to avoid running clusters being used by tests.

[alexzielenski]

/label tide/merge-method-squash
/approve
/lgtm

I am curious whether #17 and #22 together will cause the GitHub test to fail in CI.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexzielenski, eddycharly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alexzielenski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment