Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from record.EventRecorder to events.EventRecorder #2675

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vladikkuzn
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

It will be useful to distinguish between a "regular" workload finish (when the job ends) versus another kind of failure, in a machine readable way.

Which issue(s) this PR fixes:

Fixes #1481

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vladikkuzn
Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from denkensk and mimowo July 22, 2024 22:57
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 006767f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/669ee3c03801e300087192bc
😎 Deploy Preview https://deploy-preview-2675--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vladikkuzn
Copy link
Contributor Author

/test all

@vladikkuzn
Copy link
Contributor Author

/assign

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@vladikkuzn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-e2e-main-1-27 006767f link true /test pull-kueue-test-e2e-main-1-27
pull-kueue-test-e2e-main-1-28 006767f link true /test pull-kueue-test-e2e-main-1-28
pull-kueue-build-image-main 006767f link true /test pull-kueue-build-image-main
pull-kueue-test-unit-main 006767f link true /test pull-kueue-test-unit-main
pull-kueue-test-e2e-main-1-29 006767f link true /test pull-kueue-test-e2e-main-1-29
pull-kueue-test-e2e-main-1-30 006767f link true /test pull-kueue-test-e2e-main-1-30
pull-kueue-verify-main 006767f link true /test pull-kueue-verify-main
pull-kueue-test-tas-e2e-main 006767f link true /test pull-kueue-test-tas-e2e-main
pull-kueue-test-scheduling-perf-main 006767f link true /test pull-kueue-test-scheduling-perf-main
pull-kueue-test-e2e-main-1-31 006767f link true /test pull-kueue-test-e2e-main-1-31
pull-kueue-test-integration-main 006767f link true /test pull-kueue-test-integration-main
pull-kueue-test-multikueue-e2e-main 006767f link true /test pull-kueue-test-multikueue-e2e-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to the new event recorder in Kueue
2 participants