-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LeaderWorkerSet integration #3515
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vladikkuzn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
342d0de
to
4519993
Compare
/test all |
ff26e24
to
6630f22
Compare
6630f22
to
3036113
Compare
workerTemplateGroupNameLabelPath, | ||
)...) | ||
|
||
// TODO(#...): support resizes later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO create issue
sizePath, | ||
)...) | ||
|
||
// TODO(#...): support mutation of leader/worker templates later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO create issue
34aa49c
to
87e9fda
Compare
/cc @mimowo |
@vladikkuzn: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
87e9fda
to
3a1234d
Compare
/assign |
3a1234d
to
9f80991
Compare
9f80991
to
385a13a
Compare
385a13a
to
9c42cad
Compare
9c42cad
to
62a7661
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds LeaderWorkerSet integration to job framework
Which issue(s) this PR fixes:
Fixes #3232
Special notes for your reviewer:
Does this PR introduce a user-facing change?