Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics e2e tests #3881

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add metrics e2e tests #3881

wants to merge 1 commit into from

Conversation

mykysha
Copy link
Contributor

@mykysha mykysha commented Dec 18, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Adds sanity tests for general and local queue metrics

Which issue(s) this PR fixes:

Fixes #3746

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mykysha. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mykysha
Once this PR has been reviewed and has the lgtm label, please assign trasc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 18, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 18, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 297b90d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67657a902a17b200085b19dc

@mykysha
Copy link
Contributor Author

mykysha commented Dec 18, 2024

/cc @mbobrovskyi

@mbobrovskyi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2024
@mimowo
Copy link
Contributor

mimowo commented Dec 18, 2024

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2024
@kannon92
Copy link
Contributor

/ok-to-test

mbobrovskyi
mbobrovskyi reviewed Dec 18, 2024
View reviewed changes
test/e2e/singlecluster/metrics_test.go
@@ -88,11 +157,39 @@ var _ = ginkgo.Describe("Metrics", func() {
}, util.LongTimeout).Should(gomega.Succeed())
})

metrics := []string{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose extending this list to cover all possible metrics. Otherwise, if an uncovered metric is removed from metrics.Register(), all tests will still pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added more metrics, but would propose to add others in a separate PR covering special cases

@mbobrovskyi
Copy link
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@mimowo mimowo Awaiting requested review from mimowo

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sanity e2e tests for the Kueue metrics
5 participants
@mykysha @k8s-ci-robot @mbobrovskyi @mimowo @kannon92