Replace time.Now() with clock.Clock.Now() in pkg/workload/admissionchecks

[TusharMohapatra07]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Replaces time.Now() to use the Now() function present inside clock package.

Which issue(s) this PR fixes:

Part of #3380

Special notes for your reviewer:

This PR is work-in-progress.

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TusharMohapatra07
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @TusharMohapatra07. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	56ad95b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/676910396af5400008f3c8fd

[TusharMohapatra07]

@mbobrovskyi Hey, can you please check if this was the refactor expected in admissionchecks.go. Post approval, i shall also proceed to update the tests.

[mbobrovskyi]

/ok-to-test

[mbobrovskyi]

/cc

[TusharMohapatra07]

@mbobrovskyi Actually, i haven't updated the tests yet. I just wanted to confirm if this is how you wanted me to fix the clock issue. I called clock to multiple levels.

[mbobrovskyi]

Overall LGTM. Please fix tests.

[TusharMohapatra07]

@mbobrovskyi i updated the test. Now, i just have to figure out one thing

kueue/cmd/importer/pod/import.go

Line 202 in 6ac33de

err := workload.ApplyAdmissionStatus(ctx, c, wl, false)

Here, we have to pass clock. I tried adding clock argument to admitWorkload but couldn't find clock instance anywhere to pass it to the function

[mbobrovskyi]

/retest

[mbobrovskyi]

@mbobrovskyi i updated the test. Now, i just have to figure out one thing

kueue/cmd/importer/pod/import.go

Line 202 in 6ac33de

err := workload.ApplyAdmissionStatus(ctx, c, wl, false)

Here, we have to pass clock. I tried adding clock argument to admitWorkload but couldn't find clock instance anywhere to pass it to the function

Mmm. Initialize new instance of clock.

[TusharMohapatra07]

Mmm. Initialize new instance of clock.

and directly pass realClock ??

[mbobrovskyi]

Mmm. Initialize new instance of clock.

and directly pass realClock ??

If it is using only one time than yes.

[TusharMohapatra07]

/retest