fix: kubectl help misformats helm help tables

and any preformatted-as-markdown tables Fixes #5080
kubernetes-sigs · Jul 2, 2020 · 356e1c0 · 356e1c0
1 parent 365b819
commit 356e1c0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/plugins/plugin-client-common/src/components/Content/Markdown.tsx b/plugins/plugin-client-common/src/components/Content/Markdown.tsx
@@ -135,7 +135,11 @@ export default class Markdown extends React.PureComponent<Props> {
             )
           },
           listItem: props => <ListItem className={props.className}>{props.children}</ListItem>,
-          table: props => <StructuredListWrapper className={props.className}>{props.children}</StructuredListWrapper>,
+          table: props => (
+            <StructuredListWrapper className={props.className + ' kui--table-like'}>
+              {props.children}
+            </StructuredListWrapper>
+          ),
           tableHead: props => <StructuredListHead className={props.className}>{props.children}</StructuredListHead>,
           tableBody: props => <StructuredListBody className={props.className}>{props.children}</StructuredListBody>,
           tableRow: props => (

diff --git a/plugins/plugin-kubectl/src/lib/util/help.ts b/plugins/plugin-kubectl/src/lib/util/help.ts
@@ -288,7 +288,7 @@ const renderHelpUnsafe = <O extends KubeOptions>(
               .join('\n')}\n`
         )
         .concat('\n\n')
-        .replace(/(--\S+)/g, '`$1`')
+        .replace(/(\s--\S+)/g, '`$1`')
         .replace(/^\n*([^\n.]+)(\.?)/, '### About\n#### $1')
         .replace(/\n\s*(Find more information at:)\s+([^\n]+)/, '') // [Find more information] will be in links below the menus
         .concat(!aliasesSection ? '' : `### Aliases\n${aliasesSection.content}`)