fix(plugins/plugin-client-common): split button errors are not report…

…ed to the user Fixes #4876
kubernetes-sigs · Jun 12, 2020 · 49990cf · 49990cf
1 parent 29c0e48
commit 49990cf
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/plugins/plugin-client-common/src/components/Client/TopTabStripe/SplitTerminalButton.tsx b/plugins/plugin-client-common/src/components/Client/TopTabStripe/SplitTerminalButton.tsx
@@ -15,14 +15,19 @@
  */
 
 import * as React from 'react'
-import { i18n } from '@kui-shell/core'
+import { i18n, pexecInCurrentTab } from '@kui-shell/core'
 
 import Icons from '../../spi/Icons'
 import KuiContext from '../context'
 import onSplit from '../../../controller/split'
 
 const strings = i18n('plugin-client-common')
 
+/**
+ * re: the impl of the onClick handler, see
+ * https://github.com/IBM/kui/issues/4876
+ *
+ */
 export default class SplitTerminalButtonButton extends React.PureComponent {
   public render() {
     return (
@@ -36,7 +41,7 @@ export default class SplitTerminalButtonButton extends React.PureComponent {
               aria-label="Split terminal"
               tabIndex={0}
               title={strings('Split the Terminal')}
-              onClick={() => onSplit()}
+              onClick={() => onSplit().catch(() => pexecInCurrentTab('split'))}
             >
               <Icons icon="Split" />
             </a>