fix(packages/webpack): allow imports of markdown and image assets

Fixes #4983
kubernetes-sigs · Jun 24, 2020 · 5a8f550 · 5a8f550
1 parent 6764be3
commit 5a8f550
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/webpack/package.json b/packages/webpack/package.json
@@ -37,7 +37,7 @@
     "css-loader": "3.6.0",
     "file-loader": "6.0.0",
     "font-config-webpack-plugin": "2.0.0",
-    "html-webpack-plugin": "^4.3.0",
+    "html-webpack-plugin": "4.3.0",
     "ignore-loader": "0.1.2",
     "mini-css-extract-plugin": "0.9.0",
     "node-loader": "0.6.0",
@@ -48,9 +48,10 @@
     "sass-loader": "8.0.2",
     "shebang-loader": "0.0.1",
     "source-map-loader": "1.0.0",
-    "style-loader": "^1.2.1",
+    "style-loader": "1.2.1",
     "svg-inline-loader": "0.8.2",
     "to-string-loader": "1.1.6",
+    "url-loader": "4.1.0",
     "webpack": "4.43.0",
     "webpack-cli": "3.3.12",
     "webpack-dev-server": "3.11.0"

diff --git a/packages/webpack/webpack.config.js b/packages/webpack/webpack.config.js
@@ -469,8 +469,8 @@ module.exports = {
       { test: /AUTHORS/, use: 'ignore-loader' },
       { test: /LICENSE/, use: 'ignore-loader' },
       { test: /license.txt/, use: 'ignore-loader' },
-      { test: /\.md$/, use: 'ignore-loader' },
-      { test: /\.markdown$/, use: 'ignore-loader' },
+      { test: /\.md$/, use: 'file-loader' },
+      { test: /\.markdown$/, use: 'file-loader' },
       { test: /~$/, use: 'ignore-loader' },
       { test: /Dockerfile$/, use: 'ignore-loader' },
       { test: /flycheck*\.js/, use: 'ignore-loader' },
@@ -481,9 +481,9 @@ module.exports = {
       // { test: /samples\/.*\.js$/, use: 'raw-loader' }, // don't try to parse out sample input, e.g. for dependencies
       // { test: /\.js.map$/, use: 'ignore-loader' },
       { test: /\.py$/, use: 'file-loader' },
-      { test: /\.ico$/, use: 'file-loader' },
-      { test: /\.jpg$/, use: 'file-loader' },
-      { test: /\.png$/, use: 'file-loader' },
+      { test: /\.ico$/, use: 'url-loader' },
+      { test: /\.jpg$/, use: 'url-loader' },
+      { test: /\.png$/, use: 'url-loader' },
       { test: /\.svg$/, use: 'svg-inline-loader' },
       { test: /\.sh$/, use: 'raw-loader' },
       { test: /\.html$/, use: 'raw-loader' },