-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Manage a specified portion of resources #1209
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for k8s-kwok canceled.
|
bf7e65d
to
4726c33
Compare
2afd06e
to
4726c33
Compare
7027e3b
to
5ba035d
Compare
5ba035d
to
8c9bd26
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref #1122
Special notes for your reviewer:
Compatibility with existing flags and configurations
This allows you to specify resources to manage, not just nodes.
Use
--manage Node:metadata.name=<nodename>
instead of--manage-single-node <nodename>
.Use
--manage Node
instead of--manage-all-nodes
.Use
--manage Node:metadata.annotations.<key>=<value>
instead of--manage-nodes-with-annotation-selector <key>=<value>
.Use
--manage Node:metadata.labels.<key>=<value>
instead of--manage-nodes-with-label-selector <key>=<value>
.and have the same configuration change
[BROKEN] Use
--manage
will no longer manage all resources with Stages by default; it will only manage specified resources.Examples
Use
--manage VirtualMachineInstance.kubevirt.io/v1
to specified https://github.com/kubevirt/kubevirtci/blob/4cc10185aca83b7d884183ecf6ff7dfc040f23fc/cluster-provision/k8s/1.31/manifests/kwok/kubevirt/stage/vmi-ready.yamlDoes this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: