-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix daemonset deletion in general stage #1286
base: main
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MondayCha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @MondayCha. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-kwok canceled.
|
Signed-off-by: Yilong Li <[email protected]>
6244628
to
ff35480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove all finalizers from the general stage
/ok-to-test |
@MondayCha: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Kwok provides a WIP General Stage configuration to simulate a more comprehensive Pod lifecycle. However, when DaemonSets with tolerations configured as shown below exist, the General Stage configuration prevents these DaemonSet Pods from being garbage collected.
If users attempt to delete these Pods before deleting the node, the DaemonSet will automatically rebuild them. Therefore, for DaemonSets, users typically don't explicitly delete Pods but rather delete nodes, relying on Kubernetes' GC mechanism to delete the Pods.
However, since the General Stage adds Finalizers to all Pods, it causes Kubernetes' native GC mechanism to fail, leaving Pods stuck in the Terminating state.
To address this, this PR considers ignoring Finalizers for DaemonSet-type Pods. Additionally, it fixes the missing
startTime
field in pod-ready.yaml compared to the fast configuration.Does this PR introduce a user-facing change?
NONE