-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add kwokctlComponent API #847
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for k8s-kwok canceled.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0bec29a
to
d893645
Compare
104f3a2
to
abc2c36
Compare
2d6fcac
to
6d57c7b
Compare
8e29a06
to
d2760c1
Compare
d2760c1
to
b416a98
Compare
b416a98
to
d2535e5
Compare
d2535e5
to
7ec0f80
Compare
It would be great if you provide some example yaml for a new component with this API. |
here's an example 6603367#diff-bfbfd4fd2682d488d5d652f9835c22fdc899618dd37c72d822d46ea400cb1b03R1 The expectation is able to fully describe all components in yaml, it's on hold because I'm doing something else. |
Thanks for pointing him out.
np, just take your time. |
ignore this, memo onlySupport for VPA
|
7ec0f80
to
bc1c2ae
Compare
71436ea
to
381eb2b
Compare
b56e76e
to
66bddac
Compare
66bddac
to
a0c49d9
Compare
a0c49d9
to
6496b32
Compare
@wzshiming: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: