Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add kwokctlComponent API #847

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wzshiming
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added the KwokctlComponent configuration to configure components.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 21, 2023
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 6496b32
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/66f687595d9c6200088adbe2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2023
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch 9 times, most recently from 0bec29a to d893645 Compare November 24, 2023 06:56
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 24, 2023
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch 9 times, most recently from 104f3a2 to abc2c36 Compare November 27, 2023 07:36
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch from 2d6fcac to 6d57c7b Compare April 1, 2024 07:44
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2024
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch 5 times, most recently from 8e29a06 to d2760c1 Compare April 8, 2024 02:29
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch from d2760c1 to b416a98 Compare April 10, 2024 08:09
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch from b416a98 to d2535e5 Compare April 22, 2024 07:09
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch from d2535e5 to 7ec0f80 Compare July 17, 2024 11:47
@liangyuanpeng
Copy link
Contributor

It would be great if you provide some example yaml for a new component with this API.

@wzshiming
Copy link
Member Author

It would be great if you provide some example yaml for a new component with this API.

here's an example

6603367#diff-bfbfd4fd2682d488d5d652f9835c22fdc899618dd37c72d822d46ea400cb1b03R1

The expectation is able to fully describe all components in yaml, it's on hold because I'm doing something else.

@liangyuanpeng
Copy link
Contributor

Thanks for pointing him out.

it's on hold because I'm doing something else.

np, just take your time.

@wzshiming
Copy link
Member Author

wzshiming commented Jul 23, 2024

ignore this, memo only

Support for VPA

#1181 (comment)

apiVersion: config.kwok.x-k8s.io/v1alpha1
kind: KwokctlConfiguration
options:
  kubeApiserverCertSANs:
  - vpa-admission-controller
components:
- name: vpa-admission-controller
  image: registry.k8s.io/autoscaling/vpa-admission-controller:1.1.2
  args:
  - --kubeconfig=/root/.kube/config
  - --client-ca-file=/etc/kubernetes/pki/ca.crt
  - --tls-cert-file=/etc/kubernetes/pki/admin.crt
  - --tls-private-key-file=/etc/kubernetes/pki/admin.key
  - --webhook-address=https://vpa-admission-controller
  - --webhook-port=8080
  - --port=8080
- name: vpa-recommender
  image: registry.k8s.io/autoscaling/vpa-recommender:1.1.2
  args:
  - --kubeconfig=/root/.kube/config
- name: vpa-updater
  image: registry.k8s.io/autoscaling/vpa-updater:1.1.2
  args:
  - --kubeconfig=/root/.kube/config

@wzshiming wzshiming force-pushed the feat/kwokctl-component branch from 7ec0f80 to bc1c2ae Compare August 26, 2024 08:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2024
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch 2 times, most recently from 71436ea to 381eb2b Compare August 26, 2024 14:40
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch 4 times, most recently from b56e76e to 66bddac Compare September 27, 2024 09:47
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch from 66bddac to a0c49d9 Compare September 27, 2024 10:14
@wzshiming wzshiming force-pushed the feat/kwokctl-component branch from a0c49d9 to 6496b32 Compare September 27, 2024 10:22
@k8s-ci-robot
Copy link
Contributor

@wzshiming: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kwok-verify-main 6496b32 link true /test pull-kwok-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants