Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.8.0 #1565

Open
1 task
slashpai opened this issue Sep 10, 2024 · 14 comments
Open
1 task

Release v0.8.0 #1565

slashpai opened this issue Sep 10, 2024 · 14 comments
Assignees
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@slashpai
Copy link
Contributor

slashpai commented Sep 10, 2024

Installation

kubectl apply -f https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.8.0/components.yaml

Changes since v0.7.2

Improvements

Tasks

Preview Give feedback
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 10, 2024
@slashpai
Copy link
Contributor Author

cc @dgrisonnet @yangjunmyfm192085

@yangjunmyfm192085
Copy link
Contributor

I am not sure whether the dependency #1559 needs to be merged together
/cc @dgrisonnet

@dgrisonnet
Copy link
Member

Yes ideally we should bump all the deps before cutting a new release

@slashpai
Copy link
Contributor Author

Go through list of open PRs:

#1522 looks to be useful fix

@dgrisonnet
Copy link
Member

The issue behind #1522 seems to be related to kubelet CSRs rather than metrics-server, but I don't have the bandwidth to really look into it

@dgrisonnet
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 10, 2024
@slashpai
Copy link
Contributor Author

updating readme and version #1567

@RainbowMango
Copy link
Member

Hi @slashpai
Could you explain why we need to update Go with v1.23 instead of v1.22?

Note that, Kubernetes v1.31 is using v1.22, and is not ready for Go v1.23. Kuberentes made some changes to adopt Go v1.23, see kubernetes/kubernetes#127271 (comment) for more details.

So, I suggest rollback to Go v1.22 if there is no specific reason for v1.23.

also cc @dgrisonnet

@slashpai
Copy link
Contributor Author

slashpai commented Dec 3, 2024

Hi @slashpai Could you explain why we need to update Go with v1.23 instead of v1.22?

Note that, Kubernetes v1.31 is using v1.22, and is not ready for Go v1.23. Kuberentes made some changes to adopt Go v1.23, see kubernetes/kubernetes#127271 (comment) for more details.

So, I suggest rollback to Go v1.22 if there is no specific reason for v1.23.

also cc @dgrisonnet

Thank you for pointing that out. Checked with @dgrisonnet, looks like there won't be a release soon and mostly would happen after Kubernetes 1.32 release which uses go 1.23.

@RainbowMango
Copy link
Member

Do you mean there won't be a release with Kubernetes v1.31? In other words, [email protected] will use Kubernetes v1.32 dependencies?

@dgrisonnet
Copy link
Member

Most likely. I won't have the bandwidth to work on a release anytime soon so it is more likely to use 1.32 by that time unless someone else take care of the release.

It is also worth noting that we still need to address #1560 (comment) before releasing

@RainbowMango
Copy link
Member

@dgrisonnet
Thanks for the clarification. I'm not sure I have the bandwidth to explore it, but I will try. And will let you know if I get any clue.

But, do you think it makes sense to revert Golang to v1.22.x? After that, at least people can import metrics-server with a pseudo version.

@slashpai Could you help to track the issue @dgrisonnet mentioned above to this issue task list?

@dgrisonnet
Copy link
Member

Can't you base yourself on cc3047e?

@RainbowMango
Copy link
Member

Yeah, it should work, I'll give it a try. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants