-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(env): add auto go maxprocs #1561
base: master
Are you sure you want to change the base?
feat(env): add auto go maxprocs #1561
Conversation
Signed-off-by: dongjiang1989 <[email protected]>
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/triage accepted |
Thanks @dgrisonnet . Can you add |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongjiang1989 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@dongjiang1989 What tests have you conducted on the PR? Would be nice to see if there is noticeable performance/latency improvement before merging. |
Signed-off-by: dongjiang1989 <[email protected]>
/test pull-metrics-server-verify |
/test pull-metrics-server-test-e2e-ha |
Signed-off-by: dongjiang1989 <[email protected]>
/test pull-metrics-server-test-e2e-helm |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What this PR does / why we need it:
this PR is about adding a new dependency on go.uber.go/automaxprocs.
auto set GOMAXPROC for metrics-server pod/container
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #