-
Notifications
You must be signed in to change notification settings - Fork 39
Update the user stories to ClusterNetworkPolicy #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bowei The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! could you also update https://github.com/kubernetes-sigs/network-policy-api/blob/main/site-src/reference/examples.md as it reuses the same examples?
Is there value in keeping the existing ANP user stories as-is for historical reasons? |
Depends on the usage -- if it's for reference, Git history is sufficient. If you want to be able to reference it online (e.g. via live hyperlink), then we need to make a copy and preserve it. I am of the opinion that the value of keeping it around is most valuable right now, but the value will keep going down from here on out -- therefore, it doesn't seem like it's that important... |
The user stories are kinda left as is, mostly the implementation yamls are being updated |
1f3a55b
to
a4c56d3
Compare
Fixes the user-story-*.yamls
a4c56d3
to
62b2836
Compare
I just updated incorporating the comments, please take a look. |
Fixes the user-story-*.yamls