-
Notifications
You must be signed in to change notification settings - Fork 809
Adding .Release.Namespace #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: asosnovsky The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @asosnovsky! |
/retest |
@asosnovsky: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kmova not sure how to proceed here, what do I need to merge this? |
I was finding that while installing this chart with terraform helm_release it would place the resources in whatever my kube_config had defined by default rather than the actual namespace specified by the chart, it seems to be due to missing explicit namespace specifications on the part of the chart.