CI: Output test coverprofile to Artifacts tab in Prow#257
Conversation
✅ Deploy Preview for node-readiness-controller canceled.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| TOOLS_DIR := hack/tools | ||
| TOOLS_BIN_DIR := $(abspath $(TOOLS_DIR)/$(BIN_DIR)) | ||
| GO_INSTALL := ./scripts/go_install.sh | ||
| ARTIFACTS ?= . |
There was a problem hiding this comment.
i would put it under either hack/tools/artifacts or something similar
There was a problem hiding this comment.
What about ./artifacts/ only?
There was a problem hiding this comment.
whatever we choose, let's make sure it is self-explanatory and added to .gitignore.
Within Kubernetes projects, I have seen a pattern of _output/* dir for collecting test artifacts, logs or binaries etc.
|
/rebase |
When run in CI, the coverprofile output from the test will be sent to the artifacts tab in Prow. When run locally, make test will output the file to the root of the repo.
vitorfloriano
force-pushed
the
ci-output-test-coverprofile-to-artifacts
branch
from
5c95242 to
ba713e9
Compare
|
I'm good with the changes as it is so far. But if you want to improve the default ARTIFACTS dir, adding a hold. (feel free to unhold) /lgtm (@ajaysundark, for approve label. Thanks!) |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
4 participants
When run in Prow,
make testwill output thecoverprofilefile to$ARTIFACTS, which is a directory already present and exported by Prow when usingdecorate: truein the job description, and will show up in the Artifacts tab in spyglass.When run locally,
make testwill output the file to the root of the repo, as it is currently.See: https://docs.prow.k8s.io/docs/components/pod-utilities/#what-the-test-container-can-expect
Follow-up to kubernetes/test-infra#37035