AppArmor profile binding

[k0vd3n]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for App Armor profile binding

Which issue(s) this PR fixes:

None

Does this PR have test?

No

Special notes for your reviewer:

Please review my app armor profile binding implementation and cover it with tests. I would appreciate any feedback.

Does this PR introduce a user-facing change?

This change introduces new configuration options for App Armor profiles.

This commit adds support for App Armor profile binding

[linux-foundation-easycla]

• ✅login: dependabot[bot] / (bbb937c)
• ✅login: k0vd3n / (d13f23e)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @k0vd3n!

It looks like this is your first PR to kubernetes-sigs/security-profiles-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/security-profiles-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @k0vd3n. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k0vd3n
Once this PR has been reviewed and has the lgtm label, please assign pjbgf for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[saschagrunert]

@k0vd3n thank you for the PR! Do you mind signing the CLA?

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 28.07692% with 187 lines in your changes missing coverage. Please review.

Project coverage is 41.11%. Comparing base (11d77f4) to head (d13f23e).
Report is 453 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2510      +/-   ##
==========================================
- Coverage   45.50%   41.11%   -4.39%     
==========================================
  Files          79      109      +30     
  Lines        7782    18456   +10674     
==========================================
+ Hits         3541     7588    +4047     
- Misses       4099    10364    +6265     
- Partials      142      504     +362     

[k0vd3n]

@k0vd3n thank you for the PR! Do you mind signing the CLA?

Thank you for pointing that out! I have now signed the CLA, and the status has been updated.

[saschagrunert]

/ok-to-test

[saschagrunert]

We can't use go 1.23 right now, because the go-toolset does not have it: https://catalog.redhat.com/software/containers/rhel8/go-toolset

[k0vd3n]

The Kubernetes API that supports AppArmor Profile starts from version 0.30.0, which requires Go 1.22. However, the Go toolset only supports up to Go 1.21. This creates a problem, as I can’t use the necessary API while staying within the supported Go version

[k8s-ci-robot]

@k0vd3n: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-security-profiles-operator-verify	d13f23e	link	true	/test pull-security-profiles-operator-verify
pull-security-profiles-operator-build-image	d13f23e	link	true	/test pull-security-profiles-operator-build-image
pull-security-profiles-operator-test-e2e	d13f23e	link	true	/test pull-security-profiles-operator-test-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[saschagrunert]

@k0vd3n do you mind a rebase?

[k0vd3n]

@saschagrunert I’ll try to rebase and update the pull request as soon as I have some free time.

Thanks for your patience!