Skip to content

slack-welcomer: fix ingress API, update welcome message, fix container name#77

Open
Champbreed wants to merge 1 commit into
kubernetes-sigs:mainfrom
Champbreed:fix/ingress-and-welcomer-updates
Open

slack-welcomer: fix ingress API, update welcome message, fix container name#77
Champbreed wants to merge 1 commit into
kubernetes-sigs:mainfrom
Champbreed:fix/ingress-and-welcomer-updates

Conversation

@Champbreed

Copy link
Copy Markdown

This PR migrates cluster/ingress.yaml from the deprecated extensions/v1beta1 to networking.k8s.io/v1 with updated backend syntax, replaces all broken git.k8s.io links in message.yaml with working GitHub paths while adding the Slack Guidelines and updating channels, also fixes a container naming typo in deployment.yaml where the container was labeled slack-moderator instead of slack-welcomer.

/sig contributor-experience
/cc @jberkus @mrbobbytables @BenTheElder @Priyankasaggu11929

Fixes #76

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Champbreed
Once this PR has been reviewed and has the lgtm label, please assign coderanger for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @Champbreed!

It looks like this is your first PR to kubernetes-sigs/slack-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/slack-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 8, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @Champbreed. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2026
@Champbreed Champbreed force-pushed the fix/ingress-and-welcomer-updates branch from cd6c48e to 7f86bed Compare June 8, 2026 22:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 8, 2026
@Champbreed

Copy link
Copy Markdown
Author

/ok-to-test

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@Champbreed: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jberkus

jberkus commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploying replacement Slack welcome bot and updating cluster configurations

3 participants