-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test changes related to StoragePolicy in vSphere CSI plugin #2896
Conversation
Hi @vdkotkar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@vdkotkar: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, vdkotkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We have some unit tests in CSI where we are using default StoragePolicy created in PBM ("vSAN Default Storage Policy") and using it for CreateVolume request. But actual code where we are checking if datastore is compatible with storage policy was not getting traversed, as we were passing following parameter for CreateVolume request:
params["checkCompatibleDatastores"] = "false"
After doing some analysis found that we suppressed the code path mentioned above for unit testing, as we were getting following error from pbm simulator:
failed to find datastore compatibility with storage policy ID <storage-policy-ID>. Error: ServerFaultCode: PbmPlacementSolver:placementSolver does not implement: PbmCheckCompatibility
Made changes in govmomi pbm simulator through PR vmware/govmomi#3431 to fix this issue.
So, after this fix there is no need to suppress the code path where we are checking if datastore is compatible with the storage policy.
Also, added a new unit test to create new StoragePolicy and sending this policy for CreateVolume request.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done:
All unit tests are passing with these changes.
Special notes for your reviewer:
Release note: