Skip to content

Conversation

@jrvaldes
Copy link
Contributor

Azure CLI installation reliability:

  • Added a new function ensure_azcli_with_retry() that attempts to install Azure CLI up to five times with exponential backoff, logging each attempt and showing logs from failed attempts if installation does not succeed.
  • Updated the set_azure_envs() function to use ensure_azcli_with_retry() instead of directly sourcing ensure-azcli.sh, exiting with an error if installation fails.

Cleanup logic:

  • Improved robustness of the cleanup process by checking if capz::ci-build-azure-ccm::cleanup is defined before calling it, and logging a warning if not found.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrvaldes
Once this PR has been reviewed and has the lgtm label, please assign claudiubelu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2025
@jrvaldes jrvaldes changed the title capz: use retry wrapper to ensure-azcli.sh and run ci-build-azure-ccm::cleanup only if present Use retry wrapper to ensure-azcli.sh and run ci-build-azure-ccm::cleanup only if present Oct 29, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 29, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jrvaldes. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2025
@aravindhp
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
@jrvaldes jrvaldes force-pushed the improve-func-errors branch from 6af632b to 89d719a Compare October 29, 2025 21:18
@jrvaldes
Copy link
Contributor Author

@jrvaldes
Copy link
Contributor Author

@jrvaldes
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants