Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hetzner): deprecated server type will break on 2024-09-06 #7211

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

apricote
Copy link
Member

@apricote apricote commented Aug 27, 2024

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

The cx11 server type was deprecated on 2024-06-06 and will be removed from the API on 2024-09-06. Once it is removed, the cluster-autoscaler provider hetzner will fail every main loop with with the following error messages:

mixed_nodeinfos_processor.go:160] Unable to build proper template node for draining-node-pool: failed to create resource list for node group draining-node-pool error: failed to get machine type cx11 info error: server type not found
static_autoscaler.go:387] Failed to get node infos for groups: failed to create resource list for node group draining-node-pool error: failed to get machine type cx11 info error: server type not found

The server type is hardcoded in the draining-node-pool, which was used in the OG PR #3640 but unused in the second PR #3838 that was actually merged.

As the draining-node-pool is unused since the first release of this provider, I have opted to remove it altogether. In theory this is a user visible change, as this node pool is visible through the status config map

Which issue(s) this PR fixes:

Fixes #7210

Special notes for your reviewer:

We would like to back port this change to all actives releases ASAP. If you think this change does not qualify for a back port, I am happy to submit a different PR that only changes the hardcoded server type to one that will be available for longer.

This one is one me. I should have noticed this reference when checking our projects for hardcoded cx11 references when the deprecation was announced.

Does this PR introduce a user-facing change?

Fix Hetzner Provider not starting after 2024-09-07

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [Hetzner Cloud Changelog](https://docs.hetzner.cloud/changelog#2024-06-06-old-server-types-with-shared-intel-vcpus-are-deprecated)

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from x13n August 27, 2024 07:46
@k8s-ci-robot k8s-ci-robot added area/provider/hetzner Issues or PRs related to Hetzner provider approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2024
…type

The `cx11` server type was deprecated on 2024-06-06 and will be removed
from the API on 2024-09-06. Once it is removed, the cluster-autoscaler
provider hetzner will not start anymore with the following error
message:

    Failed to get node infos for groups: failed to create resource list for node group draining-node-pool error: failed to get machine type cx11 info error: server type not found

As the node pool `draining-node-pool` is not being used anywhere, this
commit removes it and the hard coded reference to the deprecated server
type.
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, jooola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@apricote
Copy link
Member Author

@Shubham82 @x13n Could you take a look at this? We would really appreciate it if we can get this in the next patch releases.


Sorry to keep annoying you with our PRs. We have a new colleague starting in our team to work on our Kubernetes integrations, so I am optimistic that we can get the second owner in the coming months.

@Shubham82
Copy link
Contributor

We would like to back port this change to all actives releases ASAP. If you think this change does not qualify for a back port, I am happy to submit a different PR that only changes the hardcoded server type to one that will be available for longer.

@apricote, IMO we can backport this in the supported CA version also.

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit a5e46eb into kubernetes:master Sep 23, 2024
6 checks passed
@apricote
Copy link
Member Author

Thanks @Shubham82!

I am working on the backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/hetzner Issues or PRs related to Hetzner provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard-coded server type in Hetzner provider will break on 2024-09-06
4 participants