-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hetzner): deprecated server type will break on 2024-09-06 #7211
fix(hetzner): deprecated server type will break on 2024-09-06 #7211
Conversation
…type The `cx11` server type was deprecated on 2024-06-06 and will be removed from the API on 2024-09-06. Once it is removed, the cluster-autoscaler provider hetzner will not start anymore with the following error message: Failed to get node infos for groups: failed to create resource list for node group draining-node-pool error: failed to get machine type cx11 info error: server type not found As the node pool `draining-node-pool` is not being used anywhere, this commit removes it and the hard coded reference to the deprecated server type.
f78cba3
to
eae5dd7
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, jooola The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Shubham82 @x13n Could you take a look at this? We would really appreciate it if we can get this in the next patch releases. Sorry to keep annoying you with our PRs. We have a new colleague starting in our team to work on our Kubernetes integrations, so I am optimistic that we can get the second owner in the coming months. |
@apricote, IMO we can backport this in the supported CA version also. |
/lgtm |
Thanks @Shubham82! I am working on the backports. |
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
The
cx11
server type was deprecated on 2024-06-06 and will be removed from the API on 2024-09-06. Once it is removed, the cluster-autoscaler provider hetzner will fail every main loop with with the following error messages:The server type is hardcoded in the
draining-node-pool
, which was used in the OG PR #3640 but unused in the second PR #3838 that was actually merged.As the
draining-node-pool
is unused since the first release of this provider, I have opted to remove it altogether. In theory this is a user visible change, as this node pool is visible through the status config mapWhich issue(s) this PR fixes:
Fixes #7210
Special notes for your reviewer:
We would like to back port this change to all actives releases ASAP. If you think this change does not qualify for a back port, I am happy to submit a different PR that only changes the hardcoded server type to one that will be available for longer.
This one is one me. I should have noticed this reference when checking our projects for hardcoded
cx11
references when the deprecation was announced.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: