Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cluster-autoscaler-release-1.27] azure labels to skip in nodegroupset #7265

Open
wants to merge 2 commits into
base: cluster-autoscaler-release-1.27
Choose a base branch
from
Open

[cluster-autoscaler-release-1.27] azure labels to skip in nodegroupset #7265

wants to merge 2 commits into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #6634

/assign comtalyst

Skips Azure-specific node labels that might mistakenly categorize nodegroups as different when, in reality, they are similar.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 6, 2024
Merged
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 6, 2024
charliedmcb
charliedmcb approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@comtalyst
Copy link
Contributor

/label tide/merge-method-squash
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: charliedmcb, comtalyst, k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@comtalyst
Copy link
Contributor

/assign @towca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliedmcb charliedmcb charliedmcb approved these changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@x13n x13n Awaiting requested review from x13n

Assignees

@towca towca

@comtalyst comtalyst

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k8s-infra-cherrypick-robot @comtalyst @k8s-ci-robot @charliedmcb @towca @gandhipr