Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor logging statements in recommender:checkpoint,input #7290

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Refactor logging statements in recommender:checkpoint,input #7290

merged 14 commits into from
Oct 22, 2024

Conversation

omerap12
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To align the logging with the best practices and guidelines established within the Kubernetes ecosystem.

Which issue(s) this PR fixes:

As part of #6905, I'm splitting this into multiple PRs rather than submitting a single large PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @omerap12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2024
@omerap12 omerap12 force-pushed the logging-vpa-recommender-checkpoint-input branch from b22cf35 to e06608c Compare September 17, 2024 08:31
@adrianmoisey
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2024
@omerap12
Copy link
Member Author

@adrianmoisey fixed, do you want me to rebase?

@adrianmoisey
Copy link
Member

@adrianmoisey fixed, do you want me to rebase?

Nah, I think it's fine.

@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2024
@adrianmoisey
Copy link
Member

Hey @kgolab, can you approve this?
/assign kgolab

@adrianmoisey
Copy link
Member

adrianmoisey commented Oct 8, 2024 •
edited
Loading

@omerap12 can you address the remaining comments here?

@omerap12
Copy link
Member Author

omerap12 commented Oct 8, 2024

@omerap12 can you address the remaining comments here?

Of course, I will adjust the code later

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@omerap12
Copy link
Member Author

omerap12 commented Oct 8, 2024

adjusted @adrianmoisey

@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2024
voelzmo
voelzmo suggested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@voelzmo voelzmo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change, thanks for the adaptations! Some small comments where we can simplify the logs.

Also: there's a few occasions of klog.Warningf, could you also take care of those, while we're at it? Thanks!

vertical-pod-autoscaler/pkg/recommender/checkpoint/checkpoint_writer.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/recommender/checkpoint/checkpoint_writer.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go Outdated Show resolved Hide resolved
vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go Outdated Show resolved Hide resolved
@voelzmo
Copy link
Contributor

voelzmo commented Oct 18, 2024

/unassign @jbartosik

@voelzmo
Copy link
Contributor

voelzmo commented Oct 18, 2024

/assign
/unassign @kgolab

@k8s-ci-robot k8s-ci-robot assigned voelzmo and unassigned kgolab Oct 18, 2024
@omerap12 @voelzmo
using klog.KRef
bb24a34 
Co-authored-by: Marco Voelz <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2024
omerap12 and others added 6 commits October 18, 2024 16:06
@omerap12 @voelzmo
using klog.KRef
b972340 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
922d806 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
692aa93 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
Fixed typo
0ad3ac5 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
fd32d88 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12 @voelzmo
using klog.KRef
ce3b9f2 
Co-authored-by: Marco Voelz <[email protected]>
@omerap12
Copy link
Member Author

This is a great change, thanks for the adaptations! Some small comments where we can simplify the logs.

Also: there's a few occasions of klog.Warningf, could you also take care of those, while we're at it? Thanks!

Thanks for your review! Ill just pinned this ( no need to discuss things twice 😄 )

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 20, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Oct 22, 2024

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerap12, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 26b82f0 into kubernetes:master Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voelzmo voelzmo voelzmo requested changes

@jbartosik jbartosik Awaiting requested review from jbartosik

@adrianmoisey adrianmoisey Awaiting requested review from adrianmoisey

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

Assignees

@adrianmoisey adrianmoisey

@voelzmo voelzmo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@omerap12 @k8s-ci-robot @adrianmoisey @voelzmo @kwiesmueller @kgolab