Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified new-contributor-resource #8199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmanSarraf
Copy link

Which issue(s) this PR fixes:

Fixes #8152
@kaslin

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @AmanSarraf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. label Dec 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmanSarraf
Once this PR has been reviewed and has the lgtm label, please assign kaslin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Dec 2, 2024
@palnabarun
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 3, 2024
@palnabarun
Copy link
Member

/cc @kaslin @mfahlandt

@palnabarun
Copy link
Member

palnabarun commented Dec 3, 2024

@AmanSarraf -- FYI, a PR was already created 2 weeks back. Request you to work together on the change.

#8153

Comment on lines +33 to +34
Access a curated [list of resources](https://bit.ly/kubernetes-resources) for contributors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a blocker for this PR, but I'd say that we really need another PR to integrate the resource list with the main docs instead of linking to a Gist written by Dims 3 years ago. I'll open an issue.

- Participate in channels of SIGs you're interested in.

## 2. Learn and Get Familiar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we mention the New Contributor Orientation in this section?

Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up this page! I've asked for one change before merging.

Also, I'm going to open up a follow-up issue for something else that needs to be fixed.

@henriquesantanati
Copy link

@jberkus , hope you are doing well.

Curious to know why this PR was prioritized in favor of 8153 opened on Nov 20th. Could you please clarify?

Since this is my first try on collaborating with the community, I'd like to improve anything that I could be done differently.

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mentorship-planning Relating to strategy, planning,& executing of mentoring programs. NOT specific mentoring opportunty. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance readability of Kubernetes contributor onboarding guide
5 participants