-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified new-contributor-resource #8199
base: master
Are you sure you want to change the base?
Conversation
Hi @AmanSarraf. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AmanSarraf The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/cc @kaslin @mfahlandt |
@AmanSarraf -- FYI, a PR was already created 2 weeks back. Request you to work together on the change. |
Access a curated [list of resources](https://bit.ly/kubernetes-resources) for contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a blocker for this PR, but I'd say that we really need another PR to integrate the resource list with the main docs instead of linking to a Gist written by Dims 3 years ago. I'll open an issue.
- Participate in channels of SIGs you're interested in. | ||
|
||
## 2. Learn and Get Familiar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we mention the New Contributor Orientation in this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up this page! I've asked for one change before merging.
Also, I'm going to open up a follow-up issue for something else that needs to be fixed.
Which issue(s) this PR fixes:
Fixes #8152
@kaslin