Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added wg-policy-spotlight blog #534

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

arujjval
Copy link
Contributor

closes #533

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @arujjval!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2024
Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving the answers to the questions onto a new line to improve readability?

Copy link
Member

@ArvindParekh ArvindParekh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going through this again and found some nits :)

content/en/blog/2024/wg-policy-spotlight-2024.md Outdated Show resolved Hide resolved
content/en/blog/2024/wg-policy-spotlight-2024.md Outdated Show resolved Hide resolved
@arujjval
Copy link
Contributor Author

@ArvindParekh updated as per your comments.

@chris-short
Copy link
Contributor

Please update the date. After that, I'll lgtm and approve and we'll get this published.

@sftim
Copy link
Contributor

sftim commented Jan 10, 2025

/hold

We'd usually mirror this kind of article to the main blog. Are we happy to hold off to allow for that?

OK to unhold if we don't want mirroring.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2025
@chris-short
Copy link
Contributor

Yes, we should mirror (thank you, vacation brain is real).

@kaslin
Copy link
Contributor

kaslin commented Jan 17, 2025

Do we need to do anything in particular for the mirroring? @arujjval we need to get a new publish date for this, right?

@sftim
Copy link
Contributor

sftim commented Jan 17, 2025

Needs a contributor to open a k/website PR that mirrors this one.
It's OK to put draft: true in front matter on these BTW.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arujjval, bashlion
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@arujjval
Copy link
Contributor Author

@sftim so I have to make a similar PR at here?

Also, need to discuss the date it needs to get published.

@chris-short
Copy link
Contributor

Correct, @arujjval, that's the right place. We would want to copy it there and set the canonical URL to the contributor-site URL. In that PR for the website repo, state that reviews are taking place in the contributor-site pull request and to request edits on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotlight: WG Policy
7 participants