Skip to content

Conversation

@carlbraganza
Copy link
Contributor

Updated the KEP with relevant changes in the CSI spec and the external snapshot metadata sidecar repository.

and the external snapshot metadata sidecar repository.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @carlbraganza. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Oct 27, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlbraganza
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 27, 2025
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2025
Comment on lines +879 to +884
> Note: It is the backup application's responsibility to determine if the
underlying CSI driver provides this support.
If it does, the backup application should take that into consideration in
its snapshot retention policy, and should save the CSI snapshot handle
somewhere for future use if it deletes the `VolumeSnapshot` object
immediately after it has performed a backup.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any consideration to how backup application could delete the underlying snapshot handle from storage infra or is that left to the storage infra application outside the scope of backup application responsibility?

Copy link
Contributor Author

@carlbraganza carlbraganza Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. In discussions in the WG meeting we decided that this issue is beyond the scope of the spec.

That would be something between the backup application and the storage infrastructure. The spec does not require support for 0 snapshot retention to exist; this change merely allows CBT to be used in such a circumstance.

In practical terms, in the only supported case that I'm aware of (VMware), and I believe there is no need to "delete" the previous snapshot handle, because it is just a tag in the disk file metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants