Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure NEG Readiness Reflector commits endpoints from non-default subnets. #2727

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Ensure NEG Readiness Reflector commits endpoints from non-default subnets. #2727

wants to merge 14 commits into from

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Nov 4, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 4, 2024
@sawsa307 sawsa307 changed the title Ensure NEG Readiness Reflector commit endpoints from non-default subnets. Ensure NEG Readiness Reflector commits endpoints from non-default subnets. Nov 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please ask for approval from gauravkghildiyal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sawsa307 sawsa307 force-pushed the commit-non-default-neg-ep branch 2 times, most recently from 90ff992 to e82e8ff Compare November 5, 2024 20:59
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@sawsa307
Update namer interface to include NonDefaultSubnetNEG
460f7d6
@sawsa307
Exclude NodeTopologyInformer from hasSynced.
fd001e7 
* Remove NodeTopologyInformer from controller context hasSynced so it
  won't block controllers from starting up in case of the CRD or CR does
  not exist.
@sawsa307
Add NodeTopologyInformer to zoneGetter.
be3c372
@sawsa307
Fall back to only include default if nodeTopology CR isn't ready.
6e42596
@sawsa307
Create additional NEGs based on subnets in Node Topology CR.
055d691 
* Query Node Topology CR for the current set of NEGs in the cluster.
* When ensureNetworkEndpointGroups(), ensure NEGs are properly
  provisioned in the non-default subnets as well.
@sawsa307
Use correct namer based on the NEG type.
927b120
@sawsa307
fixup! Fall back to only include default if nodeTopology CR isn't ready.
2e9a180
@sawsa307
fixup! Create additional NEGs based on subnets in Node Topology CR.
037a763
@sawsa307
fixup! Use correct namer based on the NEG type.
cd6e627
@sawsa307
fixup! Use correct namer based on the NEG type.
7724945
@sawsa307
fixup! Fall back to only include default if nodeTopology CR isn't ready.
20d4578
@sawsa307
Export NegMeta.
07cb8c2
@sawsa307
Update test cases for readiness reflector related to msc.
7a865c7 
* Update endpointMaps in testReflector to be pollMap so it is consistent
  with the actual implementation.
* Update endpointGroupInfo to include subnet in its value.
@sawsa307 sawsa307 marked this pull request as draft November 19, 2024 21:26
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@sawsa307 sawsa307 marked this pull request as ready for review November 19, 2024 21:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@panslava panslava Awaiting requested review from panslava

@gauravkghildiyal gauravkghildiyal Awaiting requested review from gauravkghildiyal

Assignees

@gauravkghildiyal gauravkghildiyal

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sawsa307 @k8s-ci-robot @gauravkghildiyal