Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleway: IPAM integration #16016

Merged
merged 2 commits into from
Oct 21, 2023
Merged

scaleway: IPAM integration #16016

merged 2 commits into from
Oct 21, 2023

Conversation

Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Oct 11, 2023

Since the release of IPAM at Scaleway, some services (like load-balancers) no longer work with the IP provided by the instance API.
This PR makes all kOps components use the IPs from IPAM instead.

A PR has also been made on the etcd-manager and works together with this one.

This is the first step for the integration of private networks, which is coming soon.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Mia-Cross. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the area/provider/scaleway Issues or PRs related to Scaleway provider label Oct 11, 2023
@hakman
Copy link
Member

hakman commented Oct 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2023
@Mia-Cross Mia-Cross marked this pull request as ready for review October 13, 2023 12:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2023
@Mia-Cross
Copy link
Contributor Author

As it is in this PR, the code works for clusters with DNS and with no DNS, but not for those with gossip DNS because the initialization of the secondary gossip fails. This is due to the fact that the memberlistmesh package expects only private IPs, which are not provided by IPAM, whereas the legacy instance private IPs don't work anymore.

This problem will be fixed in the next PR implementing private networks since it will allow instances to have a private IP provided by IPAM.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2023
@hakman
Copy link
Member

hakman commented Oct 21, 2023

/test all

@hakman
Copy link
Member

hakman commented Oct 21, 2023

/test pull-kops-kubernetes-e2e-ubuntu-gce-build

@k8s-ci-robot k8s-ci-robot merged commit 70bba2e into kubernetes:master Oct 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/scaleway Issues or PRs related to Scaleway provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants