-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaleway: IPAM integration #16016
scaleway: IPAM integration #16016
Conversation
Hi @Mia-Cross. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
As it is in this PR, the code works for clusters with DNS and with no DNS, but not for those with gossip DNS because the initialization of the secondary gossip fails. This is due to the fact that the This problem will be fixed in the next PR implementing private networks since it will allow instances to have a private IP provided by IPAM. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/test pull-kops-kubernetes-e2e-ubuntu-gce-build |
Since the release of IPAM at Scaleway, some services (like load-balancers) no longer work with the IP provided by the instance API.
This PR makes all kOps components use the IPs from IPAM instead.
A PR has also been made on the etcd-manager and works together with this one.
This is the first step for the integration of private networks, which is coming soon.