-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase CCM workers to speed up node bootstrap process #16256
Conversation
/test presubmit-kops-aws-scale-amazonvpc-using-cl2 |
Seeing rate limiting in CCM logs with |
@@ -95,7 +95,7 @@ create_args+=("--image=${INSTANCE_IMAGE:-ssm:/aws/service/canonical/ubuntu/serve | |||
create_args+=("--set spec.etcdClusters[0].manager.listenMetricsURLs=http://localhost:2382") | |||
create_args+=("--set spec.etcdClusters[0].manager.env=ETCD_QUOTA_BACKEND_BYTES=8589934592") | |||
create_args+=("--set spec.etcdClusters[1].manager.env=ETCD_QUOTA_BACKEND_BYTES=8589934592") | |||
create_args+=("--set spec.cloudControllerManager.concurrentNodeSyncs=5") | |||
create_args+=("--set spec.cloudControllerManager.concurrentNodeSyncs=30") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be enough for now. There's no additional speed going further.
create_args+=("--set spec.cloudControllerManager.concurrentNodeSyncs=30") | |
create_args+=("--set spec.cloudControllerManager.concurrentNodeSyncs=10") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hakman did you notice client-side rate liming when you were testing out with 20
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, but i also did not notice any visible gains
Co-authored-by: Ciprian Hacman <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@hakman I think we can merge these changes. |
No description provided.