gce: fix nlb firewall rules, operations and alias network subnets #16265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/provider/gcp
hakman
reviewed
Jan 20, 2024
| @@ -108,7 +108,8 @@ func waitForOp(op *compute.Operation, getOperation func(operationName string) (* | |||
| } | |||
| pollOp, err := getOperation(opName) | |||
| if err != nil { | |||
| klog.Warningf("GCE poll operation %s failed: pollOp: [%v] err: [%v] getErrorFromOp: [%v]", opName, pollOp, err, getErrorFromOp(pollOp)) | |||
| klog.Warningf("GCE poll operation %s failed: pollOp: [%v] err: [%v]", opName, pollOp, err) | |||
| klog.Infof("getErrorFromOp: [%v]", getErrorFromOp(pollOp)) | |||
There was a problem hiding this comment.
Suggested change
| klog.Infof("getErrorFromOp: [%v]", getErrorFromOp(pollOp)) | |
| klog.Warningf("GCE poll getErrorFromOp: [%v]", getErrorFromOp(pollOp)) |
There was a problem hiding this comment.
here is the problem
W1231 23:57:40.606721 75771 op.go:111] GCE poll operation operation-1704067055308-60dd707814e11-4ceef041-b4b17b9e failed: pollOp: [<nil>] err: [googleapi: Error 403: Quota exceeded for quota metric 'Heavy-weight read requests' and limit 'Heavy-weight read requests per minute per region' of service 'compute.googleapis.com' for consumer 'project_number:189277497252'.
Details:
[
{
"@type": "type.googleapis.com/google.rpc.ErrorInfo",
"domain": "googleapis.com",
"metadatas": {
"consumer": "projects/189277497252",
"quota_limit": "HeavyWeightReadRequestsPerMinutePerProjectPerRegion",
"quota_limit_value": "1500",
"quota_location": "us-east1",
"quota_metric": "compute.googleapis.com/heavy_weight_read_requests_per_region",
"service": "compute.googleapis.com"
},
"reason": "RATE_LIMIT_EXCEEDED"
},
{
"@type": "type.googleapis.com/google.rpc.Help",
"links": [
{
"description": "Request a higher quota limit.",
"url": "https://cloud.google.com/docs/quota#requesting_higher_quota"
}
]
}
]
, rateLimitExceeded]
I1231 23:57:40.606831 75771 op.go:112] getErrorFromOp: [<nil>]
I need to hide that json block as it bloats the log file. It is a transient error that disappears after a minute usually for operations.
upodroid
force-pushed
the
network-patch
branch
from
3386976 to
f3bc523
Compare
hakman
approved these changes
Jan 20, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting #16181 to separate PRs
This one fixes bugs in GCE infra creation.