Split internal and external kube-apiserver addresses

[justinsb]

This allows us to select the right IP address when we have multiple
load balancers (one for internal, one for external) as we are planning
to have on GCE.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[justinsb]

Renamed to KopsControllerInternal, and also expanded the comments for the enum values (in pkg/wellknownservices/wellknownservices.go)

I'm using "Internal" for in-cluster traffic, and "External" for other traffic. InCluster might be clearer than Internal, but I don't know what a better name would be for External...

[justinsb]

WDYT @hakman ... I can probably make #16249 work in a different way, but right now that PR depends on this one (and I think that one is comparatively more important!)

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[justinsb]

The approach we took in #16379 replaces the need for this (at least that's the belief!)

/close

[k8s-ci-robot]

@justinsb: Closed this PR.

Details

In response to this:

The approach we took in #16379 replaces the need for this (at least that's the belief!)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.