Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(channels): promote alpha to stable #16306

Merged

Conversation

moshevayner
Copy link
Member

What this PR does / why we need it:
Promotes alpha channel to stable channel with changes from #16284

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2024
@k8s-ci-robot k8s-ci-robot requested a review from hakman February 1, 2024 18:08
@@ -103,137 +103,137 @@ spec:
networking:
kubenet: {}
kubernetesVersions:
- range: ">=1.28.0"
recommendedVersion: 1.28.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshevayner Could revert the indentation change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, VSCode on a new computer 🤦🏼‍♂️
Sure, let me take care of that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakman done!

@moshevayner moshevayner force-pushed the promote-alpha-to-stable-2024-02-01 branch from ece0961 to 9dd9396 Compare February 1, 2024 18:38
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@moshevayner
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 977d346 into kubernetes:master Feb 1, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 1, 2024
@moshevayner moshevayner deleted the promote-alpha-to-stable-2024-02-01 branch February 1, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/channels cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants