Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip gen-cli-docs on depup #16321

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Feb 4, 2024

This is preventing the dependencies update action to finish and show errors in tests:
https://github.com/kubernetes/kops/actions/runs/7752057353

GOOS=linux GOARCH=amd64 go build  "-trimpath"  -o /home/runner/work/kops/kops/.build/dist/linux/amd64/kops -ldflags=all=" -X k8s.io/kops.Version=1.29.0-alpha.4+1067b62 -X k8s.io/kops.GitVersion=1067b62" k8s.io/kops/cmd/kops
KOPS_STATE_STORE= \
KOPS_FEATURE_FLAGS= \
/home/runner/work/kops/kops/.build/dist/linux/amd64/kops gen-cli-docs --out docs/cli
Error: cannot merge resource due to conflicting Schema URL
make: *** [Makefile:276: gen-cli-docs] Error 1
Error: Process completed with exit code 2.

/cc @rifelpet @justinsb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 4, 2024
@justinsb
Copy link
Member

justinsb commented Feb 4, 2024

Thanks, and agree this doesn't feel related to dependency updates.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit a024d38 into kubernetes:master Feb 4, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants