Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Bump to Go 1.24 #17295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Bump to Go 1.24 #17295

wants to merge 2 commits into from
+62 −60

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Mar 1, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2025
@ameukam
Copy link
Member Author

ameukam commented Mar 1, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2025
ameukam
ameukam commented Mar 1, 2025
View reviewed changes
cloudbuild.yaml
@@ -2,64 +2,64 @@
timeout: 1800s
options:
substitution_option: ALLOW_LOOSE
machineType: 'N1_HIGHCPU_32'
machineType: "E2_HIGHCPU_32"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N1 instances are deprecated on CloudBuild: https://cloud.google.com/build/docs/api/reference/rest/v1/projects.builds#machinetype

ameukam
ameukam commented Mar 1, 2025
View reviewed changes
cloudbuild.yaml Outdated
args:
- cloudbuild-artifacts
# Push the images
- name: "mirror.gcr.io/library/golang:1.24.0-bookworm"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New rate limit rule on Docker Hub: https://docs.docker.com/docker-hub/usage/

@ameukam ameukam changed the title Bump to Go 1.24 [WIP] Bump to Go 1.24 Mar 1, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2025
ameukam added 2 commits March 5, 2025 18:51
@ameukam
Bump to Go 1.24
1fa3240 
https://tip.golang.org/doc/go1.24

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Increase the key size for KubeConfig private key
c6640ac 
It's now required to have a minimum of 1024 bits the RSA private key.
https://pkg.go.dev/crypto/rsa@master#GenerateKey

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@ameukam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-test c6640ac link true /test pull-kops-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameukam @k8s-ci-robot