change repo-path default fo release-note generate

kubernetes · Feb 8, 2024 · 7d433dd · 7d433dd
1 parent b201694
commit 7d433dd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/cmd/release-notes/generate.go b/cmd/release-notes/generate.go
@@ -18,8 +18,6 @@ package main
 
 import (
 	"fmt"
-	"os"
-	"path/filepath"
 	"strings"
 
 	"github.com/spf13/cobra"
@@ -120,7 +118,7 @@ func addGenerateFlags(subcommand *cobra.Command) {
 	subcommand.PersistentFlags().StringVar(
 		&opts.RepoPath,
 		"repo-path",
-		env.Default("REPO_PATH", filepath.Join(os.TempDir(), "k8s-repo")),
+		env.Default("REPO_PATH", ""),
 		"Path to a local Kubernetes repository, used only for tag discovery.",
 	)
 

diff --git a/pkg/notes/options/options.go b/pkg/notes/options/options.go
@@ -20,6 +20,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"path/filepath"
 	"strings"
 
 	"github.com/sirupsen/logrus"
@@ -194,6 +195,11 @@ func (o *Options) ValidateAndFinish() (err error) {
 		)
 	}
 
+	// Set RepoPath to <tempdir>/<gh-org>-<gh-repo> if empty
+	if o.RepoPath == "" {
+		o.RepoPath = filepath.Join(os.TempDir(), fmt.Sprintf("%s-%s", o.GithubOrg, o.GithubRepo))
+	}
+
 	// Check if we want to automatically discover the revisions
 	if o.DiscoverMode != RevisionDiscoveryModeNONE {
 		if err := o.resolveDiscoverMode(); err != nil {