Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config for go1.20 for distroless-iptables #3312

Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 9, 2023

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Currently, we only build the distroless-iptables for the main branch, but the active release branches also get go updates and other dependencies, we also should update distrolless-iptables to the active branches and keep those up-to-date

  • add config for go1.20 for distroless-iptables

/assign @jeremyrickard @saschagrunert @Verolop @ameukam
cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add config for go1.20 for distroless-iptables

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 9, 2023
@k8s-ci-robot k8s-ci-robot requested review from dcbw and jrsapi October 9, 2023 09:47
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
@cpanato
Copy link
Member Author

cpanato commented Oct 9, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2023
@cpanato cpanato force-pushed the add-distroless-active-branch branch from cefc06c to b76cf8d Compare October 9, 2023 09:52
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@cpanato cpanato force-pushed the add-distroless-active-branch branch from b76cf8d to cb85d0a Compare October 9, 2023 09:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@cpanato cpanato force-pushed the add-distroless-active-branch branch from cb85d0a to 09eb720 Compare October 9, 2023 10:05
@cpanato
Copy link
Member Author

cpanato commented Oct 9, 2023

@saschagrunert @jeremyrickard @xmudrii @kubernetes/release-engineering

there are quite a few changes when we upgrade from bullseye to bookworm in the bash scripts, and will require to maintain both things, if that is fine I will make some adjustments to make that work, otherwise we will need to decide if the work makes sense

@cpanato
Copy link
Member Author

cpanato commented Oct 9, 2023

/lgtm cancel

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2023
@cpanato cpanato force-pushed the add-distroless-active-branch branch from 09eb720 to 599315b Compare November 19, 2023 13:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2023
@cpanato cpanato force-pushed the add-distroless-active-branch branch from 599315b to 18a45b2 Compare November 19, 2023 14:58
@cpanato
Copy link
Member Author

cpanato commented Nov 19, 2023

/assign @saschagrunert @xmudrii @puerco PTAL

@k8s-ci-robot
Copy link
Contributor

@cpanato: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @saschagrunert @xmudrii @puerco PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 872e2d8 into kubernetes:master Nov 20, 2023
5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 20, 2023
@cpanato cpanato deleted the add-distroless-active-branch branch November 20, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants