-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add config for go1.20 for distroless-iptables #3312
add config for go1.20 for distroless-iptables #3312
Conversation
/hold |
cefc06c
to
b76cf8d
Compare
b76cf8d
to
cb85d0a
Compare
cb85d0a
to
09eb720
Compare
@saschagrunert @jeremyrickard @xmudrii @kubernetes/release-engineering there are quite a few changes when we upgrade from bullseye to bookworm in the bash scripts, and will require to maintain both things, if that is fine I will make some adjustments to make that work, otherwise we will need to decide if the work makes sense |
/lgtm cancel |
09eb720
to
599315b
Compare
Signed-off-by: cpanato <[email protected]>
599315b
to
18a45b2
Compare
/assign @saschagrunert @xmudrii @puerco PTAL |
@cpanato: GitHub didn't allow me to assign the following users: PTAL. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Currently, we only build the distroless-iptables for the main branch, but the active release branches also get go updates and other dependencies, we also should update distrolless-iptables to the active branches and keep those up-to-date
/assign @jeremyrickard @saschagrunert @Verolop @ameukam
cc @kubernetes/release-engineering
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?